-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add registering nav items via extension #9814
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
4f42f68
to
377defc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm biased, so another review would be appreciated, but I'm surprisingly cool with this ;-)
8ee9aa0
to
6b4863a
Compare
SonarCloud Quality Gate failed. 0 Bugs 22.6% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
very nice change 👍🏼 |
Very cool! |
Description
Nav items can be registered with the new extension type
SidebarNavExtension
, which consists of aAppNavigationItem
and optionally scopes (a list of app IDs where the nav item should show).This PR also adds 2 new optional properties to the
AppNavigationItem
interface:handler
- a click handler that get executes on click. It takes priority over a given route.priority
- a number that determines the nav item's position.Example extension:
Related Issue
Screenshots (if appropriate):
Types of changes