Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nav-Items to left sidebar #9239

Closed
Tracked by #7930
tbsbdr opened this issue Jun 15, 2023 · 6 comments · Fixed by #9814
Closed
Tracked by #7930

Add Nav-Items to left sidebar #9239

tbsbdr opened this issue Jun 15, 2023 · 6 comments · Fixed by #9814

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 15, 2023

Description

User Stories

  • As a developer I want an extension point to add Nav-Items to the left sidebar so that I am able to add additional content into an app.

Value

Acceptance Criteria

  • Add possibility for an app to register an item in the left sidebar of the files app
  • type: sidebar nav item
screenshot_001389

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues

relates to d5d936c

@tbsbdr tbsbdr mentioned this issue Jun 15, 2023
30 tasks
@tbsbdr tbsbdr changed the title Extension: Add Nav-Items to left sidebar Extension point to add Nav-Items to left sidebar Jun 15, 2023
@kulmann
Copy link
Member

kulmann commented Jun 15, 2023

@tbsbdr adjusted the user story slightly from

As a developer I want an extension point to add Nav-Items to the left sidebar so that the nav item still works after a Web UI update.

to

As a developer I want an extension point to add Nav-Items to the left sidebar so that I am able to add additional content into an app.

stability of the APIs is not a user story for this requirement, but for the extension system in general.

@kulmann
Copy link
Member

kulmann commented Jun 15, 2023

@elizavetaRa @diocas @labkode what exactly is the requirement here? Adding external links to the left sidebar, which then open in a new tab? Or adding external links to the left sidebar, which are then rendered in an iframe (requires correct CORS settings on the server!)?

@tbsbdr tbsbdr changed the title Extension point to add Nav-Items to left sidebar Add Nav-Items to left sidebar Jun 16, 2023
@kulmann
Copy link
Member

kulmann commented Jun 19, 2023

From what I know this is to be configured per app. You want it for the files app. It should be generic, so that an admin can add different nav items for different apps. Please confirm if/that this is correct.

@diocas
Copy link
Contributor

diocas commented Jun 20, 2023

I believe this is a duplicate of #5460.
The idea - initially - was to allow a different view in the files app without having to copy it. But then it became the possibility to create a shortcut (which is what we use in the CEPH, it's just a link to /ceph instead of "All files" that goes to /eos/user/etc).

But since we have a different idea for the CEPH integration (#6649) this requirement is bit open in the air.

@labkode
Copy link

labkode commented Jun 22, 2023

@kulmann on this one I would say that we need a possibility to "register" a navigation item with some weight (to control its position) where the "logic" can be:

  • point to a VueJS "page"
  • run some function

@JammingBen
Copy link
Contributor

Implemented via #9814. Please see the PR description for detailed information about how to add a nav item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants