Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9356 9362 tag form improvements #9525

Merged
merged 12 commits into from
Aug 3, 2023
Merged

9356 9362 tag form improvements #9525

merged 12 commits into from
Aug 3, 2023

Conversation

grimmoc
Copy link
Contributor

@grimmoc grimmoc commented Aug 2, 2023

Description

(from JIRA)

additional changes:

  • backspace removes last tag (improved UX)
  • added contextual helper option to OCSelect in design sytem

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Aug 2, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@grimmoc
Copy link
Contributor Author

grimmoc commented Aug 2, 2023

missing changelog, will add shortly

JammingBen
JammingBen suggested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a few small annotations.

One thing I noticed though: Removing tags via "x" vs via backspace behaves a bit differently. When removing a new tag via backspace, it will show up in the suggestions in the dropdown, whereas removing via "x" won't. Not a critical thing, I propose fixing that in a follow-up PR to get this PR merged today because of the demos tomorrow.

packages/design-system/src/components/OcSelect/OcSelect.vue Outdated Show resolved Hide resolved
packages/design-system/src/helpers/types.ts Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/TagsPanel.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/TagsPanel.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/TagsPanel.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/TagsPanel.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/TagsPanel.vue Outdated Show resolved Hide resolved
@grimmoc grimmoc marked this pull request as ready for review August 3, 2023 11:32
@JammingBen JammingBen force-pushed the 9356-9362-tag-form-improvements branch from dec9ef0 to cc7382e Compare August 3, 2023 14:56
JammingBen
JammingBen approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.8% 76.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@JammingBen JammingBen merged commit 5045545 into master Aug 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the 9356-9362-tag-form-improvements branch August 3, 2023 15:47
This was referenced Aug 8, 2023
Closed
Closed
Closed
Closed
@grimmoc grimmoc mentioned this pull request Aug 9, 2023
Merged
10 tasks
AlexAndBear pushed a commit that referenced this pull request Aug 15, 2023
@grimmoc
9356 9362 tag form improvements (#9525)
881241d 
* tag styling complete

* auto save complete

* show only not selected tags as available

* WIP button contextual helper for tags

* fixed unit tests

* linting

* set options, type hinting

* fixed after refactoring

* added changelog, PR improvements

* linting

* fixed e2e tests

* fixed bug for chrome
@JammingBen JammingBen mentioned this pull request Aug 17, 2023
Closed
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@grimmoc @AlexAndBear
9356 9362 tag form improvements (#9525)
50e8e15 
* tag styling complete

* auto save complete

* show only not selected tags as available

* WIP button contextual helper for tags

* fixed unit tests

* linting

* set options, type hinting

* fixed after refactoring

* added changelog, PR improvements

* linting

* fixed e2e tests

* fixed bug for chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grimmoc @JammingBen