Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add collapsible table and enable custom vite config for cern #9438

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

JammingBen
Copy link
Contributor

Description

Adds a custom vite config for CERN. It overwrites some of our code paths to implement custom logic that only applies to CERN. Web can be built and run using this config via pnpm build:w -c vite.cern.config.ts or pnpm vite -c vite.cern.config.ts.

This PR already includes 2 things that have been overwritten:

  • Collapsible table for the Shared with me/others views
  • A custom composable for the tokenInfo request to avoid 404 errors.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@update-docs
Copy link

update-docs bot commented Jul 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen force-pushed the custom-cern-config branch from 9065d0a to 08b1521 Compare July 19, 2023 06:45
@JammingBen JammingBen marked this pull request as ready for review July 19, 2023 06:45
This config file can be used by CERN to overwrite specific code paths and behaviors.
@JammingBen JammingBen force-pushed the custom-cern-config branch from 08b1521 to d52817b Compare July 19, 2023 06:52
@JammingBen JammingBen force-pushed the custom-cern-config branch from d52817b to 4bd2760 Compare July 19, 2023 07:22
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

5.9% 5.9% Coverage
36.7% 36.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JammingBen
Copy link
Contributor Author

@elizavetaRa @diocas Fyi this includes the collapsible table and solves the token info issue for CERN. You can simply build and run Web using a custom config provided by us via pnpm build:w -c vite.cern.config.ts or pnpm vite -c vite.cern.config.ts.

@JammingBen JammingBen merged commit a84ed82 into master Jul 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the custom-cern-config branch July 19, 2023 11:23
This was referenced Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] provide featureflag to enable collabsible tables Prevent tokeninfo request
2 participants