Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] file viewer editor close step addition #9365

Merged
merged 3 commits into from
Jul 12, 2023
Merged

[tests-only] [full-ci] file viewer editor close step addition #9365

merged 3 commits into from
Jul 12, 2023

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Jul 7, 2023 •
edited by grgprarup
Loading

Description

This PR adds the step to close the file opened in the text editor, pdf viewer, and media viewer.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • E2E tests added

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@S-Panta S-Panta self-assigned this Jul 7, 2023
@S-Panta S-Panta force-pushed the full-text-search-step-addition branch from 304d7bc to cdcbaf7 Compare July 10, 2023 03:49
@S-Panta S-Panta marked this pull request as ready for review July 10, 2023 03:52
@S-Panta S-Panta force-pushed the full-text-search-step-addition branch from cdcbaf7 to b1a79b4 Compare July 10, 2023 04:08
@S-Panta S-Panta mentioned this pull request Jul 10, 2023
Closed
grgprarup
grgprarup reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@S-Panta S-Panta requested a review from saw-jan July 10, 2023 10:18
@S-Panta S-Panta force-pushed the full-text-search-step-addition branch from b1a79b4 to a8a1d09 Compare July 11, 2023 08:52
@S-Panta S-Panta force-pushed the full-text-search-step-addition branch from 13e9b1e to 16d15d0 Compare July 11, 2023 10:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SagarGi
SagarGi reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PrajwolAmatya PrajwolAmatya merged commit fe10942 into master Jul 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the full-text-search-step-addition branch July 12, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup grgprarup approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@S-Panta S-Panta

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@S-Panta @CLAassistant @grgprarup @SagarGi @saw-jan @amrita-shrestha @PrajwolAmatya