Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] e2e tests for search #9157

Closed
exalate-issue-sync bot opened this issue Jun 6, 2023 · 4 comments
Closed

[web] e2e tests for search #9157

exalate-issue-sync bot opened this issue Jun 6, 2023 · 4 comments
Assignees

Comments

@exalate-issue-sync
Copy link

Description

Search is a fundamental feature of the product, hence it needs some e2e tests.

User Stories

  • As a owncloud we want to be sure that core features like search work as expected so that we can release without the risk of broken core features.

Value

Avoid regressions.

Acceptance Criteria

  • set up tika in docker-compose dev stack and in drone (note: tika needs to be up and running before ocis starts, so depends_on is not sufficient)
  • One big "smoke" test e2e story with a couple of search combinations being tested as follows:
    • as test background, create some files, some of them with assigned tags. make sure they are in different locations (personal space, subfolder of the personal space, maybe an incoming accepted share and a project space).
    • scenario:
      • user enters no search term, hits enter. expected: navigates to search result page, page shows "Search for files"
      • user selects a tag. expected: page updates with search result for the selected tag.
      • user enters a search term, hits enter. expected: page updates with search result for the selected tag + search term.
      • user deselects the tag. expected: page updates with search result for the search term.
      • user toggles Search in file content. expected: page updates with search result for fulltext search by the provided search term (i.e. search term is not used for file name search anymore but for file content).
      • user clicks on a .txt file in the search result. expected: text editor opens the file.
      • user closes the text editor. expected: navigates back to the search result page.
  • delete the old acceptance tests for search

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
@grgprarup
Copy link
Contributor

grgprarup commented Jun 7, 2023

Setup Tika

  • set up tika in docker-compose dev stack
  • drone
    (note: tika needs to be up and running before ocis starts, so depends_on is not sufficient)

Test to be added:

@grgprarup
Copy link
Contributor

grgprarup commented Jun 22, 2023

This PR #9238 adds a scenario for all test cases.

More Tests cases could be added

  • Search using content (Content:keyword)
  • Search using a tag (Tags:tagName)
    (web won't support it. it is not too obvious for the user. there are no hints for users, like use "Tags:" or "Content:" in the search line)

Post Task:

@SwikritiT
Copy link
Contributor

SwikritiT commented Aug 4, 2023

@SwikritiT
Copy link
Contributor

All the PR's are merged and the checklists is complete, closing this as done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants