[full-ci] [tests-only] [E2E] full text search tests added #9238

grgprarup · 2023-06-15T02:55:20Z

Description

This PR adds E2E tests for full text search.

Related Issue

Part of [web] e2e tests for search #9157

How Has This Been Tested?

locally
🤖

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

ownclouders · 2023-06-15T11:43:12Z

Results for e2e-tests oCIS-1 https://drone.owncloud.com/owncloud/web/36693/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36693/tracing/search-for-content-of-file-alice-2023-6-20-11-43-57.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36693/tracing/search-for-content-of-file-brian-2023-6-20-11-43-58.zip

ownclouders · 2023-06-20T11:06:38Z

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/36748/40/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L113.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L136.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L158.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L166.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L175.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L185.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L195.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L207.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L215.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L225.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L235.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L247.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L253.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L262.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L282.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L291.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L302.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L34.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L55.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L56.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L57.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L81.png

ownclouders · 2023-06-20T11:08:51Z

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/36721/55/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUICreateFilesFolders-createFile_feature-L13.png

webUICreateFilesFolders-createFile_feature-L19.png

webUICreateFilesFolders-createFile_feature-L25.png

webUICreateFilesFolders-createFile_feature-L31.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L19.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L20.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L21.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L22.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L23.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L24.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L25.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L26.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L43.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L44.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L60.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L61.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L62.png

webUICreateFilesFolders-createFolders_feature-L12.png

webUICreateFilesFolders-createFolders_feature-L22.png

webUICreateFilesFolders-createFolders_feature-L27.png

webUICreateFilesFolders-createFolders_feature-L33.png

webUICreateFilesFolders-createFolders_feature-L41.png

webUICreateFilesFolders-createFolders_feature-L47.png

webUICreateFilesFolders-createFolders_feature-L53.png

webUICreateFilesFolders-createFolders_feature-L61.png

webUICreateFilesFolders-createFolders_feature-L74.png

webUICreateFilesFolders-createFolders_feature-L90.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L10.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L114.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L126.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L135.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L155.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L189.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L208.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L226.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L248.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L51.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L52.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L53.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L54.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L57.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L75.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L89.png

.drone.star

docker-compose.yml

tests/e2e/cucumber/features/smoke/fullTextSearch.ocis.feature

.drone.star

ScharfViktor · 2023-06-21T13:21:34Z

We cannot run this test in ocis CI because we don't have a tika there.
Maybe we need add tag @full-search and then exclude this test in the ocis CI

We need to think this through

tests/e2e/cucumber/features/smoke/fullTextSearch.ocis.feature

grgprarup · 2023-06-22T05:53:23Z

We cannot run this test in ocis CI because we don't have a tika there. Maybe we need add tag @full-search and then exclude this test in the ocis CI

We need to think this through

Every E2E tests are running on Ocis CI, why not add tika in Ocis CI instead of skipping this test?

ScharfViktor · 2023-06-22T08:30:24Z

Every E2E tests are running on Ocis CI, why not add tika in Ocis CI instead of skipping this test?

I suggest do this gently.
When ocis gets a web bump -> the test will fail and you can easily skip this test with tags.

You can then embed the tika in ocis CI in another PR and unskip the test.

tests/e2e/support/objects/app-files/search/actions.ts

tests/e2e/support/objects/app-files/search/index.ts

sonarqubecloud · 2023-06-27T09:58:18Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

ScharfViktor · 2023-06-27T10:30:03Z

Every E2E tests are running on Ocis CI, why not add tika in Ocis CI instead of skipping this test?

I suggest do this gently. When ocis gets a web bump -> the test will fail and you can easily skip this test with tags.

You can then embed the tika in ocis CI in another PR and unskip the test.

LGTM. Only you haven't solved the issue of this. or we don't merge into stable branch until we'll get tika in ocis?

saw-jan · 2023-06-27T10:56:03Z

Maybe one of the PR from owncloud/ocis#6606 can implement tika service in oCIS and then we can move forward to port this PR to the stable branch
CC @grgprarup @ScharfViktor

SwikritiT

LGTM

ScharfViktor · 2023-06-27T11:57:48Z

Maybe one of the PR from owncloud/ocis#6606 can implement tika service in oCIS and then we can move forward to port this PR to the stable branch CC @grgprarup @ScharfViktor

fine for me

grgprarup added the QA:team label Jun 15, 2023

grgprarup self-assigned this Jun 15, 2023

grgprarup force-pushed the setup-tika-extractor branch 3 times, most recently from b05671b to 7f43ee6 Compare June 15, 2023 11:12

grgprarup changed the title ~~[full-ci] [tests-only] Setup tika extractor~~ [full-ci] [tests-only] [E2E] full text search tests added Jun 15, 2023

grgprarup force-pushed the setup-tika-extractor branch from 7f43ee6 to ddc80fb Compare June 15, 2023 11:23

grgprarup force-pushed the setup-tika-extractor branch 3 times, most recently from 5cd1cea to 3b816c3 Compare June 20, 2023 10:49

grgprarup force-pushed the setup-tika-extractor branch 2 times, most recently from 09b89d7 to 66f312a Compare June 21, 2023 04:27

saw-jan reviewed Jun 21, 2023

View reviewed changes

.drone.star Outdated Show resolved Hide resolved

grgprarup marked this pull request as ready for review June 21, 2023 06:41

grgprarup requested review from saw-jan, SwikritiT, SagarGi, amrita-shrestha, PrajwolAmatya and ScharfViktor June 21, 2023 06:43

grgprarup force-pushed the setup-tika-extractor branch from f79ebcf to a1f5dca Compare June 21, 2023 07:10