[full-ci] Access denied page change message / load common theme #9263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
changed the title
lookacat
changed the title
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/36775/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36775/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-6-23-11-52-30.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36775/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-6-23-11-52-48.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36775/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2023-6-23-11-52-53.zip |
kulmann
reviewed
Jun 19, 2023
lookacat
changed the title
lookacat
force-pushed
the
access-denied-page-change-message
branch
from
6ca6ce4 to
c5dd5e0
Compare
dschmidt
reviewed
Jun 21, 2023
|
@lookacat could you please add screenshot with the config set. I'd be interested how the link will look like. merci! |
|
@tbsbdr added a second screenshot, if you hover over more it gets blue and underlined just like all our links :) |
|
Kudos, SonarCloud Quality Gate passed! |
dschmidt
approved these changes
Jun 23, 2023
JammingBen
approved these changes
Jun 23, 2023
ownclouders
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Load common theme into store * Implement url in access denied page * Fix add return * Add changelog * Update/add unittests * Update config.spec.ts * Fix typo * Rename accessDeniedHelpUrl * Fix acceptance tests, remove dev leftover * Rename more to readmore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: owncloud/ocis#6549
(without config set)
(with config set, on hover it looks like a normal link)
Description
To test it just visit /access-denied
See #9051 (comment)
Related Issue
Types of changes
Checklist:
Open tasks: