Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logged out url config #6549

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jun 19, 2023

Description

Introduce a config to set the more button url on the access denied page in web via WEB_OPTION_ACCESS_DENIED_HELP_URL.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@lookacat lookacat marked this pull request as ready for review June 19, 2023 08:50
@lookacat lookacat requested a review from kulmann as a code owner June 19, 2023 08:50
@lookacat lookacat requested review from micbar and AlexAndBear June 19, 2023 09:31
@lookacat lookacat requested review from mmattel and kulmann June 19, 2023 10:38
@mmattel
Copy link
Contributor

mmattel commented Jun 19, 2023

Question: when having webfinger:
One can provide a generic URL that the client uses to get via webfinger the final URL. This URL can by nature differ from the given one (think about a legal independent subsidery of a company) and by that using the new envvars here, the pages defined here are generic and can not contain content that differs per subsidery. Thinking into the future and when having a big corporation, they most likely want to have a page aligned to the resolved webfinger address (subsidery).

If this is not the case or doable, we then have to add some text in the web service readme to declare the behavior/situation when using webfinger.

@kulmann
Copy link
Member

kulmann commented Jun 19, 2023

Question: when having webfinger: One can provide a generic URL that the client uses to get via webfinger the final URL. This URL can by nature differ from the given one (think about a subsidery of a company) and by that using the new envvars here, the pages defined here are generic and can not contain content that differs per subsidery. Thinking into the future and when having a big cooporation, they most likely want to have a page aligned to the resolved webfinger address (subsidery).

If this is not the case or doable, we then have to add some text in the web service readme to declare the behavior/situation when using webfinger.

This config is already per instance, so it is always from the perspective of the ocis instance that was resolved for the user via webfinger.

Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs pov

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lookacat lookacat merged commit 7af64c3 into master Jun 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat-add-logged-out-url-config branch June 19, 2023 13:04
ownclouders pushed a commit that referenced this pull request Jun 19, 2023
@micbar micbar mentioned this pull request Jul 24, 2023
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants