Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy statement in account menu (authenticated) #9180

Merged
merged 9 commits into from
Jun 13, 2023
Merged

Privacy statement in account menu (authenticated) #9180

merged 9 commits into from
Jun 13, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jun 7, 2023 •
edited
Loading

Needs owncloud/ocis#6462

Description

We've added the option to add an imprint and privacy statement via the config.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@update-docs
Copy link

update-docs bot commented Jun 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review June 7, 2023 10:18
@lookacat lookacat requested review from dschmidt, kulmann and micbar and removed request for micbar June 7, 2023 11:58
@lookacat lookacat force-pushed the imprint-privacy-url branch from 5bd3af1 to 6980e16 Compare June 11, 2023 15:57
@lookacat lookacat requested review from kulmann and AlexAndBear June 11, 2023 15:57
kulmann
kulmann requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nitpick (see comments). Visual result is perfect 👍

packages/web-runtime/src/components/Topbar/UserMenu.vue Outdated Show resolved Hide resolved
packages/web-runtime/src/components/Topbar/UserMenu.vue Outdated Show resolved Hide resolved
@lookacat lookacat requested a review from kulmann June 12, 2023 15:51
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 😍

@kulmann kulmann merged commit f6d898e into master Jun 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the imprint-privacy-url branch June 13, 2023 07:57
@michaelstingl michaelstingl mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Privacy statement in account menu (authenticated)
3 participants
@lookacat @kulmann @AlexAndBear