Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add imprint and privacy url config #6462

Merged
merged 2 commits into from
Jun 7, 2023
Merged

feat: add imprint and privacy url config #6462

merged 2 commits into from
Jun 7, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jun 7, 2023

Description

Introduce a config to set the imprint and privacy URL via WEB_OPTION_IMPRINT_URL WEB_OPTION_PRIVACY_URL.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review June 7, 2023 10:00
@lookacat lookacat requested a review from kulmann as a code owner June 7, 2023 10:00
@lookacat lookacat mentioned this pull request Jun 7, 2023
Merged
10 tasks
@ownclouders
Copy link
Contributor

E2E tests failed: https://drone.owncloud.com/owncloud/ocis/23035/70/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/23035/tracing/public-link-for-space-alice-2023-6-7-10-21-50.zip

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lookacat lookacat merged commit 2b98941 into master Jun 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-imprint-privacy-urls branch June 7, 2023 13:33
ownclouders pushed a commit that referenced this pull request Jun 7, 2023
@lookacat
Merge pull request #6462 from owncloud/add-imprint-privacy-urls
68a3d24 
feat: add imprint and privacy url config
@micbar micbar mentioned this pull request Jun 8, 2023
Merged
13 tasks
@wkloucek wkloucek mentioned this pull request Jun 21, 2023
Closed
@micbar micbar mentioned this pull request Jul 24, 2023
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@micbar micbar Awaiting requested review from micbar

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @ownclouders @AlexAndBear