Fix spaces in search results #9026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
fix-spaces-in-search
branch
from
f330e9b to
6a4ba73
Compare
JammingBen
force-pushed
the
fix-spaces-in-search
branch
2 times, most recently
from
61279ce to
20a8c57
Compare
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/35634/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/35634/tracing/search-in-the-project-spaces-alice-2023-5-12-07-27-18.zip |
JammingBen
force-pushed
the
fix-spaces-in-search
branch
from
20a8c57 to
9db97c6
Compare
|
Kudos, SonarCloud Quality Gate passed! |
AlexAndBear
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wrong icons and sidebar panels for spaces in share results as well as their parent folder below the resource name.
Unfortunately, there is no convenient way to distinguish spaces from folders based on the search response form the server. Although space resources have empty permissions, which differs from folders, it doesn't feel great to distinguish them based on that attribute IMO. I'm open for suggestions though.
Related Issue
Screenshots
Types of changes