Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-app-search] No visible difference between folders and spaces in search results #8925

Closed
hurradieweltgehtunter opened this issue Apr 26, 2023 · 6 comments

Comments

@hurradieweltgehtunter
Copy link
Contributor

hurradieweltgehtunter commented Apr 26, 2023

Steps to reproduce

  1. Make sure to have min 1 folder and a space created with the same name
  2. Search this name in global search

Expected behaviour

Saerch results are somehow differentiated based on their type (folder, space, ...)

Actual behaviour

No difference visible

First search result in screenshot (top list and full view list) is a space, other are folders (see edit pen, rename possible for folders, not for spaces)

grafik

Also, I expected that the dropdown result list would segment results based in their type (see top left "Files")

https://ocis.ocis-wopi.latest.owncloud.works

@hurradieweltgehtunter hurradieweltgehtunter added the Category:Enhancement Add new functionality label Apr 26, 2023
@hurradieweltgehtunter
Copy link
Contributor Author

sth like this would be nice

grafik

@kulmann
Copy link
Member

kulmann commented Apr 28, 2023

Doable by splitting the search provider in the files app into two different providers, one filtering out spaces from the result set, the other one filtering everything but spaces out. This would be reasonable effort for the search result preview. But we should consider the full picture here - hitting Enter the user lands on a search result page. That should take the same thoughts into account.

There are some more more or less related issues:

And there is also the idea that the search preview does even more segmentations:

Nice enhancement, but needs more concepting. :-)

@tbsbdr
Copy link
Contributor

tbsbdr commented Apr 28, 2023

I'd stick to the scheme and show the following, if the result is a Space:

  1. display "Spaces" as parent folder
  2. show Space Image/Icon if

screenshot_000847

@JammingBen
Copy link
Contributor

I stumbled upon this while fixing #9022.

Doable by splitting the search provider in the files app into two different providers, one filtering out spaces from the result set, the other one filtering everything but spaces out.

@kulmann Do we really need separate search providers for this? My current fix (#9026) simply adjusts the existing search provider and returns the correct space resource if found.

@kulmann
Copy link
Member

kulmann commented May 12, 2023

I stumbled upon this while fixing #9022.

Doable by splitting the search provider in the files app into two different providers, one filtering out spaces from the result set, the other one filtering everything but spaces out.

@kulmann Do we really need separate search providers for this? My current fix (#9026) simply adjusts the existing search provider and returns the correct space resource if found.

Your solution is good. 👍

@JammingBen
Copy link
Contributor

Fixed via #9026.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants