-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web-app-search] No visible difference between folders and spaces in search results #8925
Comments
Doable by splitting the search provider in the files app into two different providers, one filtering out spaces from the result set, the other one filtering everything but spaces out. This would be reasonable effort for the search result preview. But we should consider the full picture here - hitting There are some more more or less related issues: And there is also the idea that the search preview does even more segmentations: Nice enhancement, but needs more concepting. :-) |
I stumbled upon this while fixing #9022.
@kulmann Do we really need separate search providers for this? My current fix (#9026) simply adjusts the existing search provider and returns the correct space resource if found. |
Your solution is good. 👍 |
Fixed via #9026. |
Steps to reproduce
Expected behaviour
Saerch results are somehow differentiated based on their type (folder, space, ...)
Actual behaviour
No difference visible
First search result in screenshot (top list and full view list) is a space, other are folders (see edit pen, rename possible for folders, not for spaces)
Also, I expected that the dropdown result list would segment results based in their type (see top left "Files")
https://ocis.ocis-wopi.latest.owncloud.works
The text was updated successfully, but these errors were encountered: