Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Keyboard shift + click selection selects file double #9003

Merged
merged 4 commits into from
May 9, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented May 9, 2023

Description

Fixing:
The Select all checkbox in the table header doesn't get checked
If you deselect one of the items again via click on the checkbox, the Select all checkbox gets checked (indicating that all items are selected) although one item is now deselected.
See #8989 (comment)

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@lookacat lookacat changed the base branch from master to stable-7.0 May 9, 2023 12:28
@lookacat lookacat changed the title Bugfix selection stable 7 Bugfix: Keyboard shift + click selection selects file double May 9, 2023
@lookacat lookacat marked this pull request as ready for review May 9, 2023 12:31
@AlexAndBear
Copy link
Contributor

works fine for me

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥇

@kulmann kulmann merged commit 72d435b into stable-7.0 May 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix-selection-stable-7 branch May 9, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyboard navigation -> click checkbox, press shift, click an underlying checkbox -> not all selected
3 participants