Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard navigation -> click checkbox, press shift, click an underlying checkbox -> not all selected #8989

Closed
AlexAndBear opened this issue May 5, 2023 · 1 comment · Fixed by #8993 or #9003
Assignees
Labels
Priority:p3-medium Normal priority Topic:UX-Design Type:Bug Something isn't working

Comments

@AlexAndBear
Copy link
Contributor

AlexAndBear commented May 5, 2023

@lookacat we've already spoken about that:

If I click a checkbox, press shift, and click the checkbox at the end of the list, not all items in between get selected

image

@AlexAndBear AlexAndBear changed the title keyboard navigation -> select checkbox press shift press a underlying checkbox not all selected keyboard navigation -> click checkbox, press shift, click an underlying checkbox not all selected May 6, 2023
@AlexAndBear AlexAndBear changed the title keyboard navigation -> click checkbox, press shift, click an underlying checkbox not all selected keyboard navigation -> click checkbox, press shift, click an underlying checkbox -> not all selected May 6, 2023
@kulmann kulmann added Type:Bug Something isn't working Priority:p3-medium Normal priority labels May 8, 2023
@kulmann
Copy link
Member

kulmann commented May 8, 2023

The linked PR fixes the issue but unfortunately opens up a new one.

Steps to reproduce:

  1. Have a folder with e.g. 4 files/folders
  2. Click on the first one
  3. Hold SHIFT and click the checkbox (!) of the last row

Expected behaviour

The range of files/folders gets selected AND since all items in the list have been selected the Select all checkbox in the table header also gets checked.

Actual behaviour

Actually two glitches:

  1. The Select all checkbox in the table header doesn't get checked
  2. If you deselect one of the items again via click on the checkbox, the Select all checkbox gets checked (indicating that all items are selected) although one item is now deselected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Topic:UX-Design Type:Bug Something isn't working
Projects
No open projects
Status: Done
4 participants