Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Keyboard actions shift + click on checkbox doesn't trigger se… #8993

Merged
merged 2 commits into from
May 8, 2023
Merged

Bugfix: Keyboard actions shift + click on checkbox doesn't trigger se… #8993

merged 2 commits into from
May 8, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented May 8, 2023 •
edited
Loading

…lection

Description

See #8989

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented May 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

JammingBen
JammingBen approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me 👍 Please re-target your branch to stable-7 though as this is a bug fix.

@lookacat lookacat changed the base branch from master to stable-7.0 May 8, 2023 11:52
@lookacat lookacat marked this pull request as ready for review May 8, 2023 11:52
@AlexAndBear AlexAndBear merged commit 01f555c into stable-7.0 May 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the keyboard-actions-checkbox-bugfix branch May 8, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keyboard navigation -> click checkbox, press shift, click an underlying checkbox -> not all selected
3 participants
@lookacat @AlexAndBear @JammingBen