Fix highlighting of the currently selected language #8972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschmidt
approved these changes
May 3, 2023
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
reviewed
May 3, 2023
| boolValue?: Record<string, any> | ||
| } | ||
|
|
||
| export interface AccountBundle { |
There was a problem hiding this comment.
Suggested change
| export interface AccountBundle { | |
| export interface SettingsBundle { |
| } | ||
| } | ||
|
|
||
| export interface AccountBundleSetting { |
There was a problem hiding this comment.
Suggested change
| export interface AccountBundleSetting { | |
| export interface Setting { |
| @@ -0,0 +1,53 @@ | |||
| export interface SettingValue { | |||
There was a problem hiding this comment.
Suggested change
| export interface SettingValue { | |
| export interface SettingsValue { |
| const selectedLanguageValue = ref() | ||
| const disableEmailNotificationsValue = ref() | ||
| const valuesList = ref<SettingValue[]>() | ||
| const bundlesList = ref<AccountBundle>() |
There was a problem hiding this comment.
Why is the bundles list not of type ref<AccountBundle[]>? 🤔
There was a problem hiding this comment.
Because bundlesList is actually not a list of bundles but the account bundle. Let my fix that name in a follow-up, just like the new interface names :)
This was referenced May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression due to the refactoring in #8911. Also adds proper types for the settings stuff.
Related Issue
Screenshots:
Types of changes