Disable notification emails

[AlexAndBear]

Description

Related Issue

• Fixes [Web] Prevent users being email-spammed by notifications #8904

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• ...

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[dschmidt]

There's quite a bit code duplication for the value saving, could you reduce that?

I assume something like

  const updateDisableEmailNotifications = async (option) => {
    await saveValue({
      identifier: 'disable email notifications',
      value: option,
      errorMessage: $gettext('Unable to save notifications email setting…')
    })
    disableEmailNotificationsValue.value = option
  }

should be all we need for a specific value.

[AlexAndBear]

TBD:

• Add unit tests

[ownclouders]

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35217/68/1
💥 The oCISUploadMove tests pipeline failed. The build has been cancelled.

[ownclouders]

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35217/70/1
💥 The oC10IntegrationApp1 tests pipeline failed. The build has been cancelled.

[ownclouders]

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35211/66/1
💥 The oCISSharingPublic2 tests pipeline failed. The build has been cancelled.

[ownclouders]

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35211/68/1
💥 The oCISUploadMove tests pipeline failed. The build has been cancelled.

[ownclouders]

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35211/71/1
💥 The oC10IntegrationApp2 tests pipeline failed. The build has been cancelled.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

81.9% Coverage
0.0% Duplication

[kulmann]

Love it! 💪