[full-ci] Rename roles permissions #8876

hurradieweltgehtunter · 2023-04-20T12:40:42Z

Description

Change share role and permission names.

Related Issue

Motivation and Context

Inspired by german gender-neutral terms, we also change the english terms.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised: Change of role and permission names docs-webui#126

Open tasks:

...

update-docs · 2023-04-20T12:40:46Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

packages/web-client/src/helpers/share/role.ts

ownclouders · 2023-04-20T19:16:32Z

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35209/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkCreate_feature-L11.png

webUISharingPublicBasic-publicLinkCreate_feature-L117.png

webUISharingPublicBasic-publicLinkCreate_feature-L135.png

webUISharingPublicBasic-publicLinkCreate_feature-L28.png

webUISharingPublicBasic-publicLinkCreate_feature-L99.png

ownclouders · 2023-04-20T19:33:07Z

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35209/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L33.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L34.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L35.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L54.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L55.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L56.png

hurradieweltgehtunter · 2023-04-20T19:36:52Z

needs some help with e2e and acceptance tests

packages/web-client/src/helpers/share/permission.ts

hurradieweltgehtunter · 2023-04-21T10:30:02Z

done from my side. @JammingBen or @janackermann could you please help out with the acceptance tests?

changelog/unreleased/enhancement-change-role-and-permission-names

packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue

packages/web-app-files/src/views/shares/SharedViaLink.vue

packages/web-app-files/src/views/shares/SharedWithOthers.vue

packages/web-app-files/src/components/SideBar/SideBar.vue

packages/web-app-files/src/composables/actions/files/useFileActionsEmptyTrashBin.ts

packages/web-client/src/helpers/share/role.ts

packages/web-client/src/helpers/share/permission.ts

packages/web-client/src/helpers/share/role.ts

tbsbdr

For the links I propose to change it to this wordings.

With the rewording from Recipients ... to Anyone ... I want to make clear, that solely the ownership of the link entitles you to access files - inspired by onedrive and box.com . Should add to a well informed use of public link and thus increase security / DLP
With the rewording from uploader to the "Secret File Drop" I want to highlight it as a feature as nextcloud is doing it very well

Notes

Drawback: we might need to revert Display remaining time on link shares with expiration date #8211 as the verbose link title needs more space
Invited People: This link-role might still be in the wrong drop menu and should be placed next to the actual invited people. @elizavetaRa suggested something this alike already some time ago...

Rename Link sharing roles

Internal -> Only for invited people (Menu closed)
Internal -> Invited people, Link works only for invited people. Login is required.
Viewer -> Anyone with the link can view (Menu closed)
Viewer -> Can view, Anyone with the link can view and download.
Contributor -> Anyone with the link can upload (Menu closed)
Contributor -> Can upload, Anyone with the link can view, download and upload.
Editor -> Anyone with the link can edit (Menu closed)
Editor -> Can edit, Anyone with the link can view, download, edit, delete and upload.
Uploader -> Secret File Drop (Menu closed, icon: inbox-unarchive-fill)
Uploader -> Secret File Drop, Anyone with the link can upload. Existing content is not revealed.

packages/web-client/src/helpers/share/role.ts

kulmann · 2023-04-26T10:18:52Z

packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue

@@ -7,7 +7,13 @@
        class="edit-public-link-role-dropdown-toggle oc-text-left"
        gap-size="none"
      >
-        <span class="link-current-role" v-text="$gettext(currentLinkRoleLabel)" />
+        <!-- <span class="link-current-role" v-if="currentLinkRole.name === 'internal'" v-text="$gettext(currentLinkRole.label)"></span>


Please delete the commented out lines

packages/web-app-files/src/composables/actions/files/useFileActionsEmptyTrashBin.ts

kulmann · 2023-04-26T10:22:10Z

Please rebase the PR. e2e test failure has been fixed on master.

…d/web into rename-roles-permissions

kulmann

hooray 🥳

all change requests done

hurradieweltgehtunter · 2023-04-26T13:57:57Z

sonarcloud · 2023-04-26T15:17:49Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

63.6% Coverage
0.0% Duplication

hurradieweltgehtunter added the Status:In-Progress label Apr 20, 2023

hurradieweltgehtunter self-assigned this Apr 20, 2023

hurradieweltgehtunter commented Apr 20, 2023

View reviewed changes

packages/web-client/src/helpers/share/role.ts Show resolved Hide resolved

packages/web-client/src/helpers/share/role.ts Show resolved Hide resolved

packages/web-client/src/helpers/share/role.ts Show resolved Hide resolved

hurradieweltgehtunter force-pushed the rename-roles-permissions branch from 3886a1f to bdcf55b Compare April 20, 2023 16:45

hurradieweltgehtunter force-pushed the rename-roles-permissions branch from 4f0ccb2 to 304b4ab Compare April 20, 2023 20:13

hurradieweltgehtunter commented Apr 21, 2023

View reviewed changes

packages/web-client/src/helpers/share/permission.ts Outdated Show resolved Hide resolved

hurradieweltgehtunter mentioned this pull request Apr 21, 2023

Change of role and permission names owncloud/docs-webui#126

Open

13 tasks

hurradieweltgehtunter added Status:Needs-Review Needs review from a maintainer and removed Status:In-Progress labels Apr 21, 2023

hurradieweltgehtunter requested a review from kulmann April 21, 2023 10:30

kulmann reviewed Apr 24, 2023

View reviewed changes

changelog/unreleased/enhancement-change-role-and-permission-names Outdated Show resolved Hide resolved

kulmann requested changes Apr 24, 2023

View reviewed changes

packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue Outdated Show resolved Hide resolved

packages/web-app-files/src/views/shares/SharedViaLink.vue Outdated Show resolved Hide resolved

JammingBen changed the title ~~Rename roles permissions~~ [full-ci] Rename roles permissions Apr 24, 2023

kulmann requested changes Apr 24, 2023

View reviewed changes

packages/web-app-files/src/views/shares/SharedWithOthers.vue Outdated Show resolved Hide resolved

JammingBen requested a review from tbsbdr April 24, 2023 11:23

tbsbdr suggested changes Apr 24, 2023

View reviewed changes

tbsbdr previously requested changes Apr 25, 2023

View reviewed changes

packages/web-client/src/helpers/share/role.ts Outdated Show resolved Hide resolved

kulmann requested changes Apr 26, 2023

View reviewed changes

packages/web-client/src/helpers/share/role.ts Outdated Show resolved Hide resolved

hurradieweltgehtunter requested review from kulmann and tbsbdr April 26, 2023 08:54

kulmann reviewed Apr 26, 2023

View reviewed changes

kulmann requested changes Apr 26, 2023

View reviewed changes

packages/web-app-files/src/composables/actions/files/useFileActionsEmptyTrashBin.ts Outdated Show resolved Hide resolved

Update label

9e08aee

hurradieweltgehtunter and others added 15 commits April 26, 2023 15:05

lint

9b3e399

update snapshots

c5afd84

update changelog

1978c70

fix text and icon

c3e8560

Update snapshots

1546652

Run linter

fb4611f

fix icon

165d5bf

changes

98fcf18

add custom texts

e72648f

set correct role labels

7098e59

lint + snapshots

809b1fe

use longLabel instead of concat

bca77ed

fixes

ce98e4f

fix texts

3e75adc

Merge branch 'rename-roles-permissions' of https://github.com/ownclou…

37029f7

…d/web into rename-roles-permissions

kulmann approved these changes Apr 26, 2023

View reviewed changes

Fix acceptance tests

30b5e2a

JammingBen added 2 commits April 26, 2023 16:29

Fix more acceptance tests

f22ce08

Fix even more acceptance tests

6519030

kulmann merged commit 335078c into master Apr 26, 2023

delete-merged-branch bot deleted the rename-roles-permissions branch April 26, 2023 18:56

SwikritiT mentioned this pull request Apr 27, 2023

e2e tests related to public link role failed in nightly #8930

Closed

SagarGi mentioned this pull request Apr 27, 2023

[tests-only][full-ci]Added display role text change before assertion #8934

Merged

tbsbdr mentioned this pull request Apr 27, 2023

leftovers roles rewording #8940

Closed

SagarGi mentioned this pull request Apr 27, 2023

Refactor role name in feature file and adjust test according to webUI #8941

Closed

1 task

micbar mentioned this pull request May 3, 2023

Release 3.0.0 RC1 owncloud/ocis#6105

Closed

89 tasks

ScharfViktor mentioned this pull request May 4, 2023

Release 3.0.0 RC4, RC5 and final owncloud/ocis#6230

Closed

86 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[full-ci] Rename roles permissions #8876

[full-ci] Rename roles permissions #8876

hurradieweltgehtunter commented Apr 20, 2023 •

edited

Loading

update-docs bot commented Apr 20, 2023

ownclouders commented Apr 20, 2023 •

edited

Loading

webUISharingPublicBasic-publicLinkCreate_feature-L11.png

webUISharingPublicBasic-publicLinkCreate_feature-L117.png

webUISharingPublicBasic-publicLinkCreate_feature-L135.png

webUISharingPublicBasic-publicLinkCreate_feature-L28.png

webUISharingPublicBasic-publicLinkCreate_feature-L99.png

ownclouders commented Apr 20, 2023 •

edited

Loading

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L33.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L34.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L35.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L54.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L55.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L56.png

hurradieweltgehtunter commented Apr 20, 2023

hurradieweltgehtunter commented Apr 21, 2023

tbsbdr left a comment •

edited

Loading

kulmann Apr 26, 2023

kulmann commented Apr 26, 2023

kulmann left a comment •

edited

Loading

hurradieweltgehtunter commented Apr 26, 2023

sonarcloud bot commented Apr 26, 2023

[full-ci] Rename roles permissions #8876

[full-ci] Rename roles permissions #8876

Conversation

hurradieweltgehtunter commented Apr 20, 2023 • edited Loading

Description

Related Issue

Motivation and Context

Types of changes

Checklist:

Open tasks:

update-docs bot commented Apr 20, 2023

ownclouders commented Apr 20, 2023 • edited Loading

webUISharingPublicBasic-publicLinkCreate_feature-L11.png

webUISharingPublicBasic-publicLinkCreate_feature-L117.png

webUISharingPublicBasic-publicLinkCreate_feature-L135.png

webUISharingPublicBasic-publicLinkCreate_feature-L28.png

webUISharingPublicBasic-publicLinkCreate_feature-L99.png

ownclouders commented Apr 20, 2023 • edited Loading

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L33.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L34.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L35.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L54.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L55.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L56.png

hurradieweltgehtunter commented Apr 20, 2023

hurradieweltgehtunter commented Apr 21, 2023

tbsbdr left a comment • edited Loading

Choose a reason for hiding this comment

kulmann Apr 26, 2023

Choose a reason for hiding this comment

kulmann commented Apr 26, 2023

kulmann left a comment • edited Loading

Choose a reason for hiding this comment

hurradieweltgehtunter commented Apr 26, 2023

sonarcloud bot commented Apr 26, 2023

hurradieweltgehtunter commented Apr 20, 2023 •

edited

Loading

ownclouders commented Apr 20, 2023 •

edited

Loading

ownclouders commented Apr 20, 2023 •

edited

Loading

tbsbdr left a comment •

edited

Loading

kulmann left a comment •

edited

Loading