fix: query param handling in AuthService.signInCallback #8782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dschmidt
force-pushed
the
authservice-signincallback-query-params
branch
from
5971852 to
bea60a2
Compare
dschmidt
requested review from
JammingBen,
kulmann and
fschade
and removed request for
JammingBen and
kulmann
dschmidt
force-pushed
the
authservice-signincallback-query-params
branch
5 times, most recently
from
a687d32 to
c2a853f
Compare
dschmidt
force-pushed
the
authservice-signincallback-query-params
branch
from
c2a853f to
4306990
Compare
|
Kudos, SonarCloud Quality Gate passed! |
JammingBen
approved these changes
Apr 6, 2023
delete-merged-branch
bot
deleted the
authservice-signincallback-query-params
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix query param handling in AuthService.signInCallback, needed at least for the
detailsparameter of private links and parameters passed to the external app (fileId, ...).Related Issue
Motivation and Context
vue-routerdoes not correctly parse query params when pushing/replacing a url with query params.We can parse them with router.resolve and pass them separately.
This makes the
detailshandling inresolvePrivateLink.vuework and also fixes the params getting lost when redirecting into the external app after sign in.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: