Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in web from Desktop currently broken #8773

Closed
micbar opened this issue Apr 4, 2023 · 4 comments · Fixed by #8782
Closed

Open in web from Desktop currently broken #8773

micbar opened this issue Apr 4, 2023 · 4 comments · Fixed by #8782
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Regression

Comments

@micbar
Copy link
Contributor

micbar commented Apr 4, 2023

Steps to reproduce

  1. Create Document.docx on the Desktop Client
  2. In file browser, open Context action "owncloud->Open in Onlyoffice"

Expected behaviour

OnlyOffice should open the app

Actual behaviour

1680645377861

Request (from mitmproxy)

POST https://0001.schule.owncloud.works/app/open-with-web
With param file_id: 0dd2c554-61ce-4c46-bceb-1962ce93fac3$ddc2004c-0977-11eb-9d3f-a793888cd0f8!84b3a190-f155-4b97-ada1-8834d45e72f4
NOTE: appName is empty

Return value

{ "uri": "https://0001.schule.owncloud.works/external?contextRouteName=files-spaces-personal&fileId=0dd2c554-61ce-4c46-bceb-1962ce93fac3%24ddc2004c-0977-11eb-9d3f-a793888cd0f8%2184b3a190-f155-4b97-ada1-8834d45e72f4"
   }

Web tries to open but cannot find an appName
empty app name

Spec

originally this was documented here https://owncloud.dev/services/app-registry/apps/#open-a-file-with-the-owncloud-web

An empty appName should open the default app.

Questions

@TheOneRing Intended to send no appName?

@dschmidt @kulmann Could that be fall out from the file action refactoring?

ownCloud Infinite Scale
Edition Community
Version 3.0.0-alpha.2+8c9c9fd2d
Web-Client-Version 7.0.0-rc.27
@micbar micbar added Type:Regression Priority:p2-high Escalation, on top of current planning, release blocker labels Apr 4, 2023
@JammingBen
Copy link
Contributor

Re-opening because it still fails on ocis.ocis-wopi. Needs further investigation.

@JammingBen JammingBen reopened this Apr 12, 2023
@dschmidt
Copy link
Member

Same error?

@JuancaG05
Copy link

Same error?

Yes, I'm working with this feature for the Android app and in ocis-wopi.latest I could reproduce this same error

@JammingBen
Copy link
Contributor

So turns out the fix is not yet released and deployed... big facepalm moment 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Regression
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants