-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix drop menu position with limited vertical screen space #8453
Conversation
3b1389c
to
8ab1f54
Compare
8ab1f54
to
d72d5f7
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it makes room for a vertical scrollbar - but why is there no vertical scrollbar?! 😄 I can only reproduce that having a vertical scrollbar visible. |
I only have the scroll bar visible during scrolling |
W00t. Which browser are you using? I tried FF and Chrome, both fine. |
Chrome |
Congratulations though, because you did reproduce it. The blue background of the I didn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Description
This changes the way how drop menus are positioned when only limited vertical screen space is available. They now fully utilize the available vertical screen space.
The issue was noticeable when the available space above and below the drop-trigger-element was not enough to hold the menu. If that's the case, we now move the drop to the top of the current container.
Related Issue
Types of changes