Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-8008: Don't open sharing sidebar after creating/copying quicklink #8036

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fix-8008: Don't open sharing sidebar after creating/copying quicklink #8036

merged 1 commit into from
Dec 5, 2022

Conversation

pascalwengerter
Copy link
Contributor

Description

Green unit tests, let's see how tightly e2e/acceptance tests are woven into this

Related Issue

@pascalwengerter pascalwengerter marked this pull request as ready for review November 29, 2022 12:30
kulmann
kulmann approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! Could you please rebase this PR to current master? The sidebar panel ids have been renamed, so this PR has conflicting files. ;-)

@ownclouders
Copy link
Contributor

ownclouders commented Nov 30, 2022 •
edited
Loading

Results for oC10SharingIntGroupsToRoot https://drone.owncloud.com/owncloud/web/30259/26/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroupsToRoot-shareWithGroups_feature-L203.png

webUISharingInternalGroupsToRoot-shareWithGroups_feature-L203.png

💥 The oC10SharingIntGroupsToRoot tests pipeline failed. The build has been cancelled.

@pascalwengerter
Copy link
Contributor Author

Results for oC10SharingIntGroupsToRoot https://drone.owncloud.com/owncloud/web/30253/26/1
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroupsToRoot-shareWithGroups_feature-L203.png

webUISharingInternalGroupsToRoot-shareWithGroups_feature-L203.png

💥 The oC10SharingIntGroupsToRoot tests pipeline failed. The build has been cancelled.

Looking at webUISharingInternalGroupsToRoot/shareWithGroups.feature:203 this looks unrelated to the changes from the PR, possibly a date issue? Re-running the test suite...

@kulmann
Copy link
Member

kulmann commented Nov 30, 2022

Results for oC10SharingIntGroupsToRoot https://drone.owncloud.com/owncloud/web/30253/26/1
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroupsToRoot-shareWithGroups_feature-L203.png

webUISharingInternalGroupsToRoot-shareWithGroups_feature-L203.png
💥 The oC10SharingIntGroupsToRoot tests pipeline failed. The build has been cancelled.

Looking at webUISharingInternalGroupsToRoot/shareWithGroups.feature:203 this looks unrelated to the changes from the PR, possibly a date issue? Re-running the test suite...

I think @JammingBen had the same experience today. Please run with [full-ci]. If that's the only failure I can do a force-merge.

@JammingBen
Copy link
Contributor

@pascalwengerter The pipeline on master has been fixed, another rebase and your PR should be good to go 👍

@pascalwengerter
Copy link
Contributor Author

@pascalwengerter The pipeline on master has been fixed, another rebase and your PR should be good to go 👍

Thanks for the reminder (and fix!), done

@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JammingBen JammingBen merged commit f6d0b87 into owncloud:master Dec 5, 2022
@pascalwengerter pascalwengerter deleted the feature/8008 branch December 21, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fileslist: Don't open sidebar if you copy the quicklink
4 participants
@pascalwengerter @ownclouders @kulmann @JammingBen