Fix-8008: Don't open sharing sidebar after creating/copying quicklink

owncloud · Nov 28, 2022 · 433207e · 433207e
1 parent 48d150f
commit 433207e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/changelog/unreleased/enhancement-no-sidebar-when-copying-quicklink b/changelog/unreleased/enhancement-no-sidebar-when-copying-quicklink
@@ -0,0 +1,6 @@
+Enhancement: Don't open sidebar when copying quicklink
+
+Following user feedback, we don't open the sharing sidebar anymore after copying/creating a quicklink.
+
+https://github.com/owncloud/web/issues/8008
+https://github.com/owncloud/web/pull/8036
diff --git a/packages/web-app-files/src/mixins/actions/createQuicklink.ts b/packages/web-app-files/src/mixins/actions/createQuicklink.ts
@@ -3,8 +3,6 @@ import { createQuicklink } from '../../helpers/share'
 import { ShareStatus } from 'web-client/src/helpers/share'
 
 import { isLocationSharesActive } from '../../router'
-import { eventBus } from 'web-pkg/src/services/eventBus'
-import { SideBarEventTopics } from '../../composables/sideBar'
 
 export default {
   computed: {
@@ -43,8 +41,6 @@ export default {
         store,
         $gettext: this.$gettext
       })
-
-      eventBus.publish(SideBarEventTopics.openWithPanel, 'sharing-item#linkShares')
     }
   }
 }
diff --git a/packages/web-app-files/src/quickActions.js b/packages/web-app-files/src/quickActions.js
@@ -67,12 +67,10 @@ export default {
       if (passwordEnforced) {
         return showQuickLinkPasswordModal(ctx, async (password) => {
           await createQuicklink({ ...ctx, resource: ctx.item, password })
-          eventBus.publish(SideBarEventTopics.openWithPanel, 'sharing-item#linkShares')
         })
       }
 
       await createQuicklink({ ...ctx, resource: ctx.item })
-      eventBus.publish(SideBarEventTopics.openWithPanel, 'sharing-item#linkShares')
     },
     displayed: canShare
   }