Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preview loading in share jail #7518

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix: preview loading in share jail #7518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/unreleased/bugfix-file-name-in-text-editor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ We've fixed a bug in the text editor where the UUID of a shared resource was bei

https://github.com/owncloud/web/pull/7516
https://github.com/owncloud/web/issues/7292
https://github.com/owncloud/web/pull/7518
8 changes: 0 additions & 8 deletions packages/web-app-files/src/components/SideBar/SideBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,14 +234,6 @@ export default defineComponent({
this.highlightedFile.webDavPath,
DavProperties.Default
)
if (
this.hasShareJail &&
(isLocationSharesActive(this.$router, 'files-shares-with-me') ||
(isLocationSpacesActive(this.$router, 'files-spaces-share') &&
this.highlightedFile.path === '/'))
) {
item.name = this.highlightedFile.name
}
JammingBen marked this conversation as resolved.
Show resolved Hide resolved
}

this.selectedFile = buildResource(item)
Expand Down
1 change: 0 additions & 1 deletion packages/web-pkg/src/helpers/preview/privatePreviewBlob.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ interface PrivatePreviewBlobOptions {
userId: string
resource: {
id: string
path: string
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated. just saw that it's unused.

webDavPath: string
etag?: string
}
Expand Down