Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preview loading in share jail #7518

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Aug 24, 2022

Description

Fixes preview loading in the right sidebar.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested a review from JammingBen August 24, 2022 20:08
@@ -9,7 +9,6 @@ interface PrivatePreviewBlobOptions {
userId: string
resource: {
id: string
path: string
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated. just saw that it's unused.

@kulmann kulmann self-assigned this Aug 24, 2022
@ownclouders
Copy link
Contributor

Results for oC10Upload https://drone.owncloud.com/owncloud/web/27799/39/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L94.png

webUIUpload-upload_feature-L94.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JammingBen JammingBen merged commit 1c7a09a into master Aug 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-preview-loading-share-jail branch August 25, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File preview in shares jail doesn't work due wrong url
3 participants