Rearange declined shares #7356
Merged
Rearange declined shares #7356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for oC10Sharing1 https://drone.owncloud.com/owncloud/web/27098/24/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIRestrictSharing-disableSharing_feature-L32.png |
kulmann
requested changes
Jul 28, 2022
There was a problem hiding this comment.
Besides a few nitpicks I only see one visual issue: The spacing above and below the "empty"-messages is off (at least too little at the bottom). That looks especially clumsy when you have neither accepted nor declined shares (see screenshot). Could you give that some attention? Otherwise super happy about this PR, the section component turned out great and the code is easier to read than before. Good job 👍
changelog/unreleased/enhancement-declined-shares-not-easily-accessible
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/Shares/SharedWithMeSection.vue
Outdated
Show resolved
Hide resolved
|
done |
|
Kudos, SonarCloud Quality Gate passed! |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhancement: Declined shares are not easily accessible
We've redesigned the 'Shared with me' page,
so the 'Declined shares' section is now displayed under the 'Accepted shares' section.
There is no need to click the toggle button anymore which makes the 'Declined shares' easily accessible.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: