-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users can't find "declined shares" #7342
Comments
@tbsbdr I don't have a strong opinion on the declined shares being collapsible or not. The idea was to declutter the view for users. Since declined shares are not what you're looking for most of the time we thought we could hide them initially and require a click to show them. Before the change with categorization of shares into three different tables we only showed one big table with pending, accepted and declined shares all mixed together. Might be ok as well to have the three different tables below each other. |
ok, so if you don't veto I'd just have "Declined shares" like the others. I guess the view could still be improved, but maybe this way has the best cost-effectiveness. updated screenshot in initial post. |
We could make it collapsible, by default expand it, and let the admin overwrite the default via config.json. I guess users of instances with lots of shares are happy about improved render speed when the declined shares are not visible at all initially. |
one thing why I thought it's not worth making "declined shares" expandable is, that i assume the number of declined shares won't break the camel's back regarding speed. My hypothesis is, that the number of declined shares is comparatively low (especially when Spaces kick in). So we might keep it simple. I could image using filter-chips in the future to reorganize the shares-view more properly (as a general pattern also with ) My short vs. long term thinking is:
would you agree for short term? |
Agreed 👍 |
Steps to reproduce
Expected behaviour
@kulmann unsure why "Declined shares" should be collapsable. It's last in list and might thereby be obsolete. what do you think - make it collapsible or just have it like pending shares?
The text was updated successfully, but these errors were encountered: