Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can't find "declined shares" #7342

Closed
tbsbdr opened this issue Jul 26, 2022 · 7 comments · Fixed by #7356
Closed

Users can't find "declined shares" #7342

tbsbdr opened this issue Jul 26, 2022 · 7 comments · Fixed by #7356
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 26, 2022

Steps to reproduce

  1. Share some files with Albert
  2. login as Albert
  3. accept a share
  4. decline a share
  5. declined shares are hard to find, "toggle" pattern is hard to understand.

Screenshot 000103

Expected behaviour

  • Declined shares should be a dedicated 3rd, collapsed (?) item at the end of the "Shared with me" list (and not a toggle next to accepted shares)

@kulmann unsure why "Declined shares" should be collapsable. It's last in list and might thereby be obsolete. what do you think - make it collapsible or just have it like pending shares?

Screenshot 000123@2x

@tbsbdr tbsbdr added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Jul 26, 2022
@kulmann
Copy link
Member

kulmann commented Jul 27, 2022

@tbsbdr I don't have a strong opinion on the declined shares being collapsible or not. The idea was to declutter the view for users. Since declined shares are not what you're looking for most of the time we thought we could hide them initially and require a click to show them.

Before the change with categorization of shares into three different tables we only showed one big table with pending, accepted and declined shares all mixed together. Might be ok as well to have the three different tables below each other.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 27, 2022

ok, so if you don't veto I'd just have "Declined shares"  like the others. I guess the view could still be improved, but maybe this way has the best cost-effectiveness.

updated screenshot in initial post.

@kulmann
Copy link
Member

kulmann commented Jul 27, 2022

We could make it collapsible, by default expand it, and let the admin overwrite the default via config.json. I guess users of instances with lots of shares are happy about improved render speed when the declined shares are not visible at all initially.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 27, 2022

one thing why I thought it's not worth making "declined shares" expandable is, that i assume the number of declined shares won't break the camel's back regarding speed. My hypothesis is, that the number of declined shares is comparatively low  (especially when Spaces kick in). So we might keep it simple.

I could image using filter-chips in the future to reorganize the shares-view more properly (as a general pattern also with )

My short vs. long term thinking is:

  • Short term (now): make it now work "good enough"
  • Long term: filter chips or similar pattern

would you agree for short term?

@kulmann
Copy link
Member

kulmann commented Jul 27, 2022

Agreed 👍

@AlexAndBear AlexAndBear self-assigned this Jul 27, 2022
@AlexAndBear
Copy link
Contributor

FYI @kulmann @kulmann : We have the possibility to only show 3 items and then show more toggle in the table footer.
Same as for pending shares, if you wish so

@kulmann
Copy link
Member

kulmann commented Jul 28, 2022

FYI @kulmann @kulmann : We have the possibility to only show 3 items and then show more toggle in the table footer.
Same as for pending shares, if you wish so

Yes, good idea. Let's do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants