Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Show file icon if no thumbnail is present #7344

Merged
merged 10 commits into from
Aug 2, 2022
Merged

[full-ci] Show file icon if no thumbnail is present #7344

merged 10 commits into from
Aug 2, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 26, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 26, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review July 26, 2022 15:50
@AlexAndBear AlexAndBear requested a review from kulmann July 26, 2022 15:53
@ownclouders
Copy link
Contributor

ownclouders commented Jul 26, 2022 •
edited
Loading

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/27209/57/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesDetails-fileDetails_feature-L47.png

webUIFilesDetails-fileDetails_feature-L47.png

webUIFilesDetails-fileDetails_feature-L67.png

webUIFilesDetails-fileDetails_feature-L67.png

kulmann
kulmann approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@kulmann kulmann changed the title Show file icon if no thumbnail is present [full-ci] Show file icon if no thumbnail is present Jul 28, 2022
@SagarGi
Copy link
Member

SagarGi commented Jul 29, 2022

I will have a look into this. @individual-it

@SagarGi SagarGi self-assigned this Jul 29, 2022
@AlexAndBear
Copy link
Contributor Author

@SagarGi
Please note: In the acceptance tests, we want to check, that the big preview icon is displayed if we are in the details panel,
if we are in a sub panel e.G sharing|actions we want to check, that the small icon is displayed

@SagarGi
Copy link
Member

SagarGi commented Jul 29, 2022

@SagarGi Please note: In the acceptance tests, we want to check, that the big preview icon is displayed if we are in the details panel, if we are in a sub panel e.G sharing|actions we want to check, that the small icon is displayed

@janackermann thank you for the information i will be checking them in both (small and big)

@SagarGi SagarGi force-pushed the issues/7337 branch 3 times, most recently from db57250 to 02cab06 Compare August 1, 2022 10:03
@SagarGi
Copy link
Member

SagarGi commented Aug 1, 2022

I have refactored some steps and code as per this comment #7344 (comment) can somebody review the test code @saw-jan @SwikritiT @kiranparajuli589 @grgprarup .

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

35.0% 35.0% Coverage
0.0% 0.0% Duplication

SwikritiT
SwikritiT reviewed Aug 2, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests LGTM

@SagarGi
Copy link
Member

SagarGi commented Aug 2, 2022 •
edited
Loading

@janackermann @individual-it Please have a look into it.

@AlexAndBear
Copy link
Contributor Author

@SagarGi LGTM, THX!

@AlexAndBear AlexAndBear merged commit 31f7426 into master Aug 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7337 branch August 2, 2022 09:30
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@kulmann kulmann kulmann approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@grgprarup grgprarup Awaiting requested review from grgprarup

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@SagarGi SagarGi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing filetype Icon in details pane
6 participants
@AlexAndBear @ownclouders @SagarGi @kulmann @kiranparajuli589 @SwikritiT