Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing filetype Icon in details pane #7337

Closed
tbsbdr opened this issue Jul 26, 2022 · 3 comments · Fixed by #7344
Closed

Missing filetype Icon in details pane #7337

tbsbdr opened this issue Jul 26, 2022 · 3 comments · Fixed by #7344
Assignees
@AlexAndBear
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 26, 2022 •
edited
Loading

Steps to reproduce

  1. open details for a resource without preview
  2. there is no icon
    Screenshot 000092

Expected behaviour

Show filetype icon in the details pane if there is not preview.

Screenshot 000094

Screenshot 000095
@tbsbdr tbsbdr added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Jul 26, 2022
@AlexAndBear
Copy link
Contributor

@tbsbdr happy with the presentation?
image

@AlexAndBear AlexAndBear self-assigned this Jul 26, 2022
@AlexAndBear AlexAndBear mentioned this issue Jul 26, 2022
Merged
10 tasks
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 26, 2022

almost happy :-) I ❤️ it as it adds more whitespace and feels more relaxed like this.
In "details" the small icon next to the resourcename should be removed to avoid duplication (also for files with a preview).
On sub-panels the small icon should be there so that the user can recognise that he/she is on the right file.
CC @kulmann

Screenshot 000108

Screenshot 000106

@AlexAndBear
Copy link
Contributor

@tbsbdr thx for feedback, implemented

@kulmann kulmann moved this to Done in Web Support Board Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexAndBear AlexAndBear

Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Web Support Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[full-ci] Show file icon if no thumbnail is present owncloud/web
2 participants
@AlexAndBear @tbsbdr