Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve table lazy loading performance #7312

Merged
merged 1 commit into from
Jul 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions changelog/unreleased/bugfix-remove-lazy-table-loading-delay

This file was deleted.

7 changes: 7 additions & 0 deletions changelog/unreleased/bugfix-table-lazy-loading-performance
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Table lazy loading performance

We've drastically increased the performance of the files table by removing the lazy loading delay and by moving the loading visualization from the OcTd to the OcTr component.

https://github.com/owncloud/web/issues/7038
https://github.com/owncloud/web/pull/7298
https://github.com/owncloud/web/pull/7312
9 changes: 5 additions & 4 deletions changelog/unreleased/enhancement-update-ods
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Enhancement: Update ODS to v14.0.0-alpha.5
Enhancement: Update ODS to v14.0.0-alpha.7

We updated the ownCloud Design System to version 14.0.0-alpha.5. Please refer to the full changelog in the ODS release (linked) for more details. Summary:
We updated the ownCloud Design System to version 14.0.0-alpha.7. Please refer to the full changelog in the ODS release (linked) for more details. Summary:

- Bugfix - Remove click event on OcIcon: #2216
- Bugfix - Lazy loading render performance: #2260
Expand All @@ -11,6 +11,7 @@ We updated the ownCloud Design System to version 14.0.0-alpha.5. Please refer to
- Enhancement - OcCheckbox add outline: #2218
- Enhancement - Progress bar indeterminate state: #2200
- Enhancement - Redesign notifications: #2210
- Enhancement - Use oc colors for selected background and deselect icon: #2262

https://github.com/owncloud/web/pull/7298
https://github.com/owncloud/owncloud-design-system/releases/tag/14.0.0-alpha.5
https://github.com/owncloud/web/pull/7312
https://github.com/owncloud/owncloud-design-system/releases/tag/v14.0.0-alpha.7
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
:selection="selection"
:sort-by="sortBy"
:sort-dir="sortDir"
:lazy="lazyLoading"
padding-x="medium"
@highlight="fileClicked"
@rowMounted="rowMounted"
Expand Down Expand Up @@ -532,16 +533,11 @@ export default defineComponent({
})
}

if (this.configuration?.options?.displayResourcesLazy) {
fields.forEach((field) =>
Object.assign(field, {
lazy: true
})
)
}

return fields
},
lazyLoading() {
return this.configuration?.options?.displayResourcesLazy
},
areAllResourcesSelected() {
return this.selection.length === this.resources.length
},
Expand Down
2 changes: 1 addition & 1 deletion packages/web-runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"luxon": "^2.4.0",
"marked": "^4.0.12",
"oidc-client-ts": "^2.0.5",
"owncloud-design-system": "14.0.0-alpha.5",
"owncloud-design-system": "14.0.0-alpha.7",
"owncloud-sdk": "~3.0.0-alpha.15",
"p-queue": "^6.6.2",
"popper-max-size-modifier": "^0.2.0",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9711,9 +9711,9 @@ __metadata:
languageName: node
linkType: hard

"owncloud-design-system@npm:14.0.0-alpha.5":
version: 14.0.0-alpha.5
resolution: "owncloud-design-system@npm:14.0.0-alpha.5"
"owncloud-design-system@npm:14.0.0-alpha.7":
version: 14.0.0-alpha.7
resolution: "owncloud-design-system@npm:14.0.0-alpha.7"
peerDependencies:
"@popperjs/core": ^2.4.0
"@vue/composition-api": ^1.4.3
Expand All @@ -9730,7 +9730,7 @@ __metadata:
vue-inline-svg: ^2.0.0
vue-select: ^3.12.0
webfontloader: ^1.6.28
checksum: bb077ebcadc8bbd812c18ce2d0cc86f53c9f7d48731bddcd630b6ae876932e2020a182f0d4768a8dec10db03624f30cf21731d7f75b874138491a582c735a575
checksum: b799e4942c0f347b739ead8fed1020343fb5a1c1d467c4082c474e484b7025bc39ec9e880fe9ea1d0e68fbc4a4a77002be7c5cb4b1fa2dbded39f736f4a0cf6f
languageName: node
linkType: hard

Expand Down Expand Up @@ -13773,7 +13773,7 @@ __metadata:
luxon: ^2.4.0
marked: ^4.0.12
oidc-client-ts: ^2.0.5
owncloud-design-system: 14.0.0-alpha.5
owncloud-design-system: 14.0.0-alpha.7
owncloud-sdk: ~3.0.0-alpha.15
p-queue: ^6.6.2
popper-max-size-modifier: ^0.2.0
Expand Down