Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve table lazy loading performance #7312

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jul 21, 2022

Description

We've increased the performance of the files table by moving the loading visualization from the OcTd to the OcTr component.

A file list with 1000 files now takes ~1,6 seconds for a complete page load, whereas before it was roughly ~3 seconds.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! ❤️

@JammingBen JammingBen marked this pull request as ready for review July 21, 2022 14:38
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 47e5365 into master Jul 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the table-lazy-loading-performance branch July 21, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants