Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace oidc-callback url with redirect url for clean browser history #7293

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Replace oidc-callback url with redirect url for clean browser history #7293

merged 1 commit into from
Jul 19, 2022

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Jul 19, 2022

Description

Replace oidc-callback url with redirect url for clean browser history.

Related Issue

Motivation and Context

  • UX: We don't want the user to go back to the oidc-callback
  • Security: We don't want to leak possibly sensitive data into the browser history

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann mentioned this pull request Jul 19, 2022
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann self-assigned this Jul 19, 2022
@kulmann kulmann merged commit 131f22d into master Jul 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the hide-oidc-callback-in-browser-history branch July 19, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

@lookacat lookacat Awaiting requested review from lookacat

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oidc-callback URL filling browser history
2 participants
@kulmann @JammingBen