Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc-callback URL filling browser history #3071

Closed
PVince81 opened this issue Feb 20, 2020 · 3 comments · Fixed by #7293
Closed

oidc-callback URL filling browser history #3071

PVince81 opened this issue Feb 20, 2020 · 3 comments · Fixed by #7293
Labels
Topic:good-first-issue beginner friendly task

Comments

@PVince81
Copy link
Contributor

I wonder if we should replace/rewrite history after processing the callback to avoid having its URL and its token stored in the browser history.

Needs some research to see if there are best practices there.

@kulmann kulmann added the Topic:good-first-issue beginner friendly task label Mar 18, 2021
@pascalwengerter
Copy link
Contributor

@kulmann @dschmidt have you touched this topic in your recent auth PR?

@dschmidt
Copy link
Member

Not specifically, to some extent the oidc library should handle it (no idea if it actually does) or if there's more we can/should do.
As I said, we did not look into this - verification if still necessary would be appreciated.

@kulmann
Copy link
Member

kulmann commented Jul 19, 2022

Didn't find much about this topic, but seems to be a good idea. And it's a one-line fix so I made a PR here #7293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic:good-first-issue beginner friendly task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants