-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Add keyboard selection / navigation #7153
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
d766c49
to
d917c35
Compare
75d91c7
to
a9904f6
Compare
Issues I've found while testing:
Bildschirmaufnahme.2022-06-24.um.10.53.44.mov
Bildschirmaufnahme.2022-06-24.um.10.56.12.mov |
f9ffa27
to
c238a71
Compare
packages/web-app-files/src/components/FilesList/ResourceTable.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/FilesList/ResourceTable.vue
Outdated
Show resolved
Hide resolved
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/26568/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/26568/tracing/file-alice-2022-6-30-03-14-51.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/26568/tracing/file-brian-2022-6-30-03-14-57.zip |
38c586c
to
2313218
Compare
2313218
to
da6bd05
Compare
92d653a
to
547aab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uha, this adds so much usability to ownCloud web 💌
I have one thing I want to request to change:
Scroll with selected focus:
Current behavior:
- upload ~100 items in one folder
- select the first item
- hit ⬇️ about 20 times
- focused item is not visible in the viewport
screenie_Brave.Browser_2022-06-29_at_13-30-40-converted.mp4
Expected behavior
- upload ~100 items in one folder
- select the first item
- hit ⬇️ about 20 times
- focused item is visible in the viewport: user always sees the current focused item
screenie_Brave.Browser_2022-06-29_at_13-27-08-converted.mp4
547aab5
to
8cf0c19
Compare
9b531ca
to
5ef4e4b
Compare
7d6fce5
to
3d1ede8
Compare
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Outdated
Description
See #6029
Needs:
owncloud/owncloud-design-system#2218
Related Issue
Types of changes
Checklist: