Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts: selection glitches #7254

Closed
2 of 3 tasks
kulmann opened this issue Jul 8, 2022 · 2 comments
Closed
2 of 3 tasks

Keyboard shortcuts: selection glitches #7254

kulmann opened this issue Jul 8, 2022 · 2 comments
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@kulmann
Copy link
Contributor

kulmann commented Jul 8, 2022

Found some small glitches in the new keyboard selection options that need a followup after #7153 got merged

  • holding down an arrow key (up/down) in the file list feels very laggy this only happened in dev build for me, not when bundled into ocis and started without a dev server. Could you still have a look please if there is something impacting the render performance?
  • having a long file list (more rows than viewport height) and going down scrolls the view (good). Going back up immediately scrolls. I'd expect that scrolling only starts again when I reach the topmost row of the viewport and continue to move up. i.e. within the rows that are visible anyway we never want to scroll. only when I am about to reach an element which is not completely in the viewport.
  • using the arrow keys (up/down) or spacebar (toggle selection) only becomes available after I made a selection with the mouse. It should be possible to use the TAB key of the keyboard to reach the file list and then use the arrow keys or spacebar respectively.
@kulmann kulmann added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker labels Jul 8, 2022
@lookacat
Copy link
Contributor

The first point I can't replicate, runs smoothly in dev build :/

@lookacat
Copy link
Contributor

@kulmann closed this issue for now, first bulletpoint is not replicatable hope it may be fixed by now otherwise reopen the issue please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants