Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloads on shared with me page #6936

Merged
merged 1 commit into from
May 12, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented May 10, 2022

Description

Single file shares and folder shares didn't have their respective download action available. (note: this is not related to the sharing jail. we just never had downloads on the shared with me page)

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann
Copy link
Member Author

kulmann commented May 10, 2022

cc @micbar

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/25485/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L22.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter pascalwengerter force-pushed the fix-single-file-share-downloads branch from f8ecb74 to 6944753 Compare May 12, 2022 20:10
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter merged commit e4bc60d into master May 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-single-file-share-downloads branch May 12, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants