Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single File user shares preview broke and download action missing #3760

Closed
micbar opened this issue May 10, 2022 · 4 comments · Fixed by #3791
Closed

Single File user shares preview broke and download action missing #3760

micbar opened this issue May 10, 2022 · 4 comments · Fixed by #3791
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@micbar
Copy link
Contributor

micbar commented May 10, 2022

Describe the bug

  1. Share A single file with user einstein
  2. Log in as einstein
  3. Browse to the shares page (No thumbnail expected for "pending" shares
  4. Accept the share

Expected behavior

See a single file in the lis with preview image and download action

Actual behavior

  • No dowload action
  • Preview is broken

Screenshot

1652194110429

Setup

https://ocis.ocis-traefik.released.owncloud.works/ ocis version 2.0.0-beta1

Additional context

Add any other context about the problem here.

@micbar micbar added Type:Bug Priority:p2-high Escalation, on top of current planning, release blocker labels May 10, 2022
@micbar micbar mentioned this issue May 10, 2022
45 tasks
@micbar
Copy link
Contributor Author

micbar commented May 10, 2022

@kulmann FYI

@kulmann
Copy link
Member

kulmann commented May 10, 2022

Download action for single files and for folders will become available in web with owncloud/web#6936
But single file shares result in download being the filename of the downloaded file

@micbar micbar self-assigned this May 11, 2022
@micbar
Copy link
Contributor Author

micbar commented May 11, 2022

@kulmann my observations are interesting.

  1. The thumbnails work if you append the Filename to the ID in the webDAV URL

  2. Where does web get the filename for the download? From the HEAD request?

@micbar
Copy link
Contributor Author

micbar commented May 12, 2022

found 2) out thanks to @fschade

It was the content disposition header. Was fixed already in reva edge cs3org/reva#2855

  1. fix PR is ready fix thumbnails for empty trailing paths #3791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants