Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement link sharing for and in spaces #6633

Merged
merged 4 commits into from
Mar 24, 2022
Merged

Implement link sharing for and in spaces #6633

merged 4 commits into from
Mar 24, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Mar 22, 2022 •
edited
Loading

Description

Spaces and their resources can now be shared via links.

Needs owncloud/owncloud-sdk#1027 to work properly. -> included via the SDK version bump.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen self-assigned this Mar 22, 2022
@owncloud owncloud deleted a comment from update-docs bot Mar 22, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Mar 22, 2022 •
edited
Loading

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/24033/71/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks_feature-L17.png

webUIPrivateLinks-accessingPrivateLinks_feature-L17.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen marked this pull request as ready for review March 22, 2022 10:09
@JammingBen JammingBen mentioned this pull request Mar 22, 2022
Merged
9 tasks
@JammingBen JammingBen force-pushed the spaces-link-sharing branch from 473ad69 to 1fe054e Compare March 23, 2022 07:26
pascalwengerter
pascalwengerter approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, needs a rebase though 🥴

@JammingBen JammingBen force-pushed the spaces-link-sharing branch from 1fe054e to 7a5399f Compare March 24, 2022 13:20
@JammingBen
Copy link
Contributor Author

Rebased :)

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

64.0% 64.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit a14605e into master Mar 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-link-sharing branch March 24, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @ownclouders @pascalwengerter