Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear who else has access to a Space #6283

Closed
exalate-issue-sync bot opened this issue Jan 19, 2022 · 5 comments
Closed

Make clear who else has access to a Space #6283

exalate-issue-sync bot opened this issue Jan 19, 2022 · 5 comments
Assignees

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Jan 19, 2022

Description

User Stories

  • As a Space Manager I want to know who is a member of the space so that I can add or remove members.

  • As a Space Member I want to know who has access to a space so that I know with whom I'm collaborating with.

  • As a Space Member I want a "at-a-glance" overview on who has access to specific files so that I'm reassured, that I don't share files accidentally with the wrong person.

Value

  • improve collaboration within spaces

Acceptance Criteria

  • Every member or manager of a space can see the full list of members and managers of the corresponding space
    • in Space root
    • in Space-subfolders
  • Managers can edit the roles of members
  • Regular members can see with whom else the Space is shared incl. roles, but members can't edit roles.
  • Share receiver can't see the list of space members (c.f. regular sharing behaviour)

List-Grouping

If there are shares, the Shared-list is split into 2 groups:

  • Shares
  • Space Members

Members- and People-Panel

  • Space-root only knows 'Members': If the user is in the space root, the "people panel" is called "Members"
    • only editable by managers
    • read-only for regular members
    • no regular sharing possible in space root)
  • Subfolders know 'Members' and 'Shares' if the user is in a space subfolder, wording stays the same as is (= People)

Shares-List group

  • If the role can be edited, the item is on top of the list (multiple editable items are sorted from A-Z)
  • After the editable items, the following items are sorted from A-Z

*Space Members group

  • Items with the role "Manager" are on top (multiple "Manger"-items are sorted from A-Z)
  • After the "Manager"-items, the following items are sorted from A-Z
  • If a Space members role had been changed for a certain folder, that member gets also listed in the "shares-list group" with the deviating role and given inheritance-indicator.

Grouping
image
relates to "Share List: Add inheritance-indicators": #6528

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] codre review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
@tbsbdr
Copy link
Contributor

tbsbdr commented Feb 2, 2022

Resource Sharing ui is utilized to list Space Members:
image
@pmaier1 Suggestion: As a regular member (non-Space-Manager), you should see the roles of the other Members (Role-picker is disabled -> read only for members) do you agree?

@pmaier1
Copy link
Contributor

pmaier1 commented Feb 2, 2022

@pmaier1 Suggestion: As a regular member (non-Space-Manager), you should see the roles of the other Members (Role-picker is disabled -> read only for members) do you agree?

Yes, full agree.

Generally speaking, I'd vote for calling the role Manager, not Space Manager.

@tbsbdr
Copy link
Contributor

tbsbdr commented Mar 4, 2022

updated ACs, added scribbles

@tbsbdr
Copy link
Contributor

tbsbdr commented Mar 9, 2022

update: removed inheritance indicators from space-members. they only add little value and got removed in favor of a more clear ui. cc @JammingBen
image

@JammingBen
Copy link
Contributor

Closing here all related PRs are finally done 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants