Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External apps by shares #5907

Merged
merged 5 commits into from
Oct 18, 2021
Merged

External apps by shares #5907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83ddc56
external apps by shares
elizavetaRa Oct 14, 2021
ba8efa1
Fix: pass fileId instead of id
elizavetaRa Oct 14, 2021
4d90045
changelog
elizavetaRa Oct 15, 2021
d1d3de4
linting
elizavetaRa Oct 15, 2021
ac18c17
Update ContextActions.spec.js
elizavetaRa Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/unreleased/bugfix-external-apps-by-shares
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Bugfix: External apps by shares

Opening shares in "Shared with me" section was broken. We have added property `mimeType` by the build of a shared resource, so that the external apps can be found for it.

We fixed passing the fileId property for the context actions.

https://github.com/owncloud/web/pull/5907
https://github.com/owncloud/web/issues/5906
2 changes: 1 addition & 1 deletion packages/web-app-files/src/components/FilesList/ContextActions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<oc-button
appearance="raw"
class="oc-text-bold"
@click="$_fileActions_openLink(app.name, item.id)"
@click="$_fileActions_openLink(app.name, item.fileId)"
>
<img :src="app.icon" :alt="`Icon for ${app.name} app`" class="oc-icon oc-icon-m" />
<span class="oc-files-context-action-label">{{ 'Open in ' + app.name }}</span>
Expand Down
1 change: 1 addition & 0 deletions packages/web-app-files/src/helpers/resources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ export function buildSharedResource(share, incomingShares = false, allowSharePer
id: share.id,
fileId: share.item_source,
type: share.item_type,
mimeType: share.state === 0 ? share.mimetype : '',
isFolder,
sdate: share.stime * 1000,
indicators: []
Expand Down
1 change: 1 addition & 0 deletions packages/web-app-files/tests/unit/components/FilesList/ContextActions.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ function getWrapper(route, { filename, extension, type = '', mimeType }, availab
propsData: {
item: {
id: 'a93f8adf==',
fileId: 'a93f8adf==',
name: filename,
path: type === 'file' ? `/${filename}.${extension}` : `/${filename}`,
mimeType,
Expand Down