-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External apps by shares #5907
External apps by shares #5907
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@elizavetaRa could you add a bugfix changelog item within this PR? And running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, code looks good, but the changelog works differently. Instead of writing to the CHANGELOG.md
, please write a changelog item. Just have a look at the changelog
folder, in the unreleased
subfolder or one of the versioned subfolders. You can copy any bugfix changelog file into the unreleased
folder and adapt it to the contents of your PR. During the next release it will be used to generate the CHANGELOG.md.
24d2669
to
2de337e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👏
Unit tests are failing. Could you please add |
Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/19722/46/1 |
Probably needs a rebase since #5806 got merged |
id is not the same by shares as by normal files, taking fileId fixes the problem with opening by external apps
SonarCloud Quality Gate failed. |
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/19766/11/1
|
Tested it, works like a charm 👌🏽 |
Description
Related Issue
Motivation and Context
I should be able to collaborate on files shared with me if permission allows!
Types of changes
Checklist: