-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback link #5468
Merged
Merged
Feedback link #5468
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8162137
Add feedback link to topbar
kulmann 22271d6
Add option to disable feedback link
kulmann d95c82f
Switch from comment to feedback icon
kulmann 8ee84cb
Modify feedback label
kulmann ab34c22
Add changelog
kulmann 23702ce
Update unit test snapshot
kulmann 76a5f07
Update VRT baseline image for oc10 topbar
kulmann ba54a9e
Update oCIS topBar baseline img
pascalwengerter f38f77a
Merge branch 'master' into feedback-link
pascalwengerter d18b6e7
Add more detailled aria attributes
kulmann e6c666b
Add unit tests for FeedbackLink
kulmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Enhancement: Feedback link | ||
|
||
We've added a feedback link in the topbar which opens a survey in a new tab. The intention is to gather feedback from users. There is a config option to disable the link (see docs "getting started"). | ||
|
||
https://github.com/owncloud/web/pull/5468 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
<template> | ||
<oc-button | ||
v-oc-tooltip="label" | ||
type="a" | ||
:href="href" | ||
target="_blank" | ||
appearance="raw" | ||
:aria-label="label" | ||
> | ||
<oc-icon name="feedback" /> | ||
</oc-button> | ||
</template> | ||
|
||
<script> | ||
export default { | ||
name: 'FeedbackLink', | ||
computed: { | ||
href() { | ||
return 'https://owncloud.com/web-design-feedback' | ||
}, | ||
label() { | ||
return this.$gettext( | ||
"Provide your feedback: We'd like to improve the web design and would be happy to hear your feedback. Thank you! Your ownCloud team." | ||
) | ||
} | ||
} | ||
} | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8149,10 +8149,10 @@ [email protected]: | |
dependencies: | ||
glob "^7.1.3" | ||
|
||
owncloud-design-system@^8.0.0-rc2: | ||
version "8.0.0-rc2" | ||
resolved "https://registry.yarnpkg.com/owncloud-design-system/-/owncloud-design-system-8.0.0-rc2.tgz#e82f948ead4f9f6258cb6bf49556da4a2aa6503b" | ||
integrity sha512-HJlI+UMN/F5cqU2KKeh0RqiLj6RLwB41xoTERUzet7hT48tDRRwBDsdXhjx4p1uqyasm2Gq1Kwqg/xe+rdJ+hg== | ||
owncloud-design-system@^8.0.0-rc3: | ||
version "8.0.0-rc3" | ||
resolved "https://registry.yarnpkg.com/owncloud-design-system/-/owncloud-design-system-8.0.0-rc3.tgz#3c471411e8b96a335f75707a6b4bf904b270015c" | ||
integrity sha512-cWUNiL0fFbusxmbP24RN9MAri8Zcx4Hc/BQP3ZDaZ3dc482Qvmde22M7cqyD63s1uV7sLdaad8MAu0FZAXVdqQ== | ||
|
||
[email protected]: | ||
version "1.0.0-2296" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if out of scope but we could load it from the theme so users can customize and re-use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone wants to have this as a feature we could do so. For now we are the ones who want that user feedback. ;-) So I'd start with the hardcoded link and see how it evolves.