Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback link #5468

Merged
merged 11 commits into from
Jul 8, 2021
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/enhancement-feedback-link
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Enhancement: Feedback link

We've added a feedback link in the topbar which opens a survey in a new tab. The intention is to gather feedback from users. There is a config option to disable the link (see docs "getting started").

https://github.com/owncloud/web/pull/5468
2 changes: 2 additions & 0 deletions docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ substring of a value of the authenticated user. Examples are `/Shares`, `/{{.Id}
- `options.disablePreviews` Set this option to `true` to disable previews in all the different file listing views. The only list view that is not affected
by this is the trash bin, as that doesn't allow showing previews at all.
- `options.previewFileExtensions` Specifies which filetypes will be previewed in the ui. For example to only preview jpg and txt files set this option to `["jpg", "txt"]`.
- `options.disableFeedbackLink` Set this option to `true` to disable the feedback link in the topbar. Keeping it enabled (value `false` or absence of the option)
allows ownCloud to get feedback from your user base through a dedicated survey website.

## Setting up backend and running

Expand Down
2 changes: 1 addition & 1 deletion packages/web-runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"lodash-es": "^4.17.21",
"luxon": "^1.27.0",
"oidc-client": "1.10.1",
"owncloud-design-system": "^8.0.0-rc2",
"owncloud-design-system": "^8.0.0-rc3",
"owncloud-sdk": "1.0.0-2296",
"p-queue": "^6.1.1",
"tippy.js": "^6.3.1",
Expand Down
28 changes: 28 additions & 0 deletions packages/web-runtime/src/components/FeedbackLink.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<template>
<oc-button
v-oc-tooltip="label"
type="a"
:href="href"
target="_blank"
appearance="raw"
:aria-label="label"
>
<oc-icon name="feedback" />
</oc-button>
</template>

<script>
export default {
name: 'FeedbackLink',
computed: {
href() {
return 'https://owncloud.com/web-design-feedback'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if out of scope but we could load it from the theme so users can customize and re-use it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone wants to have this as a feature we could do so. For now we are the ones who want that user feedback. ;-) So I'd start with the hardcoded link and see how it evolves.

},
label() {
return this.$gettext(
"Provide your feedback: We'd like to improve the web design and would be happy to hear your feedback. Thank you! Your ownCloud team."
)
}
}
}
</script>
7 changes: 7 additions & 0 deletions packages/web-runtime/src/components/TopBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<search-bar v-if="!isSearchDisabled" />
</oc-grid>
<oc-grid flex gutter="small" class="uk-width-expand uk-flex-right oc-m-rm">
<feedback-link v-if="isFeedbackLinkEnabled" />
<notifications v-if="activeNotifications.length" />
<applications-menu v-if="applicationsList.length > 0" :applications-list="applicationsList" />
<user-menu
Expand All @@ -34,9 +35,11 @@ import ApplicationsMenu from './ApplicationsMenu.vue'
import UserMenu from './UserMenu.vue'
import Notifications from './Notifications.vue'
import SearchBar from './SearchBar.vue'
import FeedbackLink from './FeedbackLink.vue'

export default {
components: {
FeedbackLink,
Notifications,
ApplicationsMenu,
UserMenu,
Expand Down Expand Up @@ -76,6 +79,10 @@ export default {
return (
this.configuration.options.hideSearchBar === true || this.$route.meta.hideSearchBar === true
)
},

isFeedbackLinkEnabled() {
return !this.configuration.options.disableFeedbackLink
}
},
methods: {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8149,10 +8149,10 @@ [email protected]:
dependencies:
glob "^7.1.3"

owncloud-design-system@^8.0.0-rc2:
version "8.0.0-rc2"
resolved "https://registry.yarnpkg.com/owncloud-design-system/-/owncloud-design-system-8.0.0-rc2.tgz#e82f948ead4f9f6258cb6bf49556da4a2aa6503b"
integrity sha512-HJlI+UMN/F5cqU2KKeh0RqiLj6RLwB41xoTERUzet7hT48tDRRwBDsdXhjx4p1uqyasm2Gq1Kwqg/xe+rdJ+hg==
owncloud-design-system@^8.0.0-rc3:
version "8.0.0-rc3"
resolved "https://registry.yarnpkg.com/owncloud-design-system/-/owncloud-design-system-8.0.0-rc3.tgz#3c471411e8b96a335f75707a6b4bf904b270015c"
integrity sha512-cWUNiL0fFbusxmbP24RN9MAri8Zcx4Hc/BQP3ZDaZ3dc482Qvmde22M7cqyD63s1uV7sLdaad8MAu0FZAXVdqQ==

[email protected]:
version "1.0.0-2296"
Expand Down