Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback link #5468

Merged
merged 11 commits into from
Jul 8, 2021
Merged

Feedback link #5468

merged 11 commits into from
Jul 8, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 7, 2021 •
edited
Loading

Description

This PR adds a feedback link to the topbar which links to a survey.

Motivation and Context

Gather user feedback.

Screenshots (if appropriate):

Screenshot 2021-07-07 at 13 48 03

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jul 7, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann self-assigned this Jul 7, 2021
pascalwengerter
pascalwengerter requested changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code-wise but needs an updated snapshot and perhaps updated VRT files, too!

packages/web-runtime/src/components/FeedbackLink.vue
name: 'FeedbackLink',
computed: {
href() {
return 'https://owncloud.com/web-design-feedback'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if out of scope but we could load it from the theme so users can customize and re-use it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone wants to have this as a feature we could do so. For now we are the ones who want that user feedback. ;-) So I'd start with the hardcoded link and see how it evolves.

@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/17149/45/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17151/49/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@fschade
Copy link
Contributor

fschade commented Jul 7, 2021

This is great, in my opinion this is good for now. In the future we could handle those things by using portals. LGMT 🚀

@kulmann kulmann requested a review from pascalwengerter July 7, 2021 20:33
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17154/49/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

pascalwengerter
pascalwengerter approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulmann kulmann merged commit 989c631 into master Jul 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the feedback-link branch July 8, 2021 07:56
ownclouders pushed a commit that referenced this pull request Jul 8, 2021
@kulmann
commit 989c631
875afbb 
Merge: 4a1cbfa e6c666b
Author: Benedikt Kulmann <[email protected]>
Date:   Thu Jul 8 09:56:35 2021 +0200

    Merge pull request #5468 from owncloud/feedback-link

    Feedback link
@micbar micbar mentioned this pull request Jul 13, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kulmann @ownclouders @fschade @pascalwengerter