Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] remove more closed issue tags from features and expected failures #5463

Merged
merged 3 commits into from
Jul 12, 2021
Merged

[tests-only] [full-ci] remove more closed issue tags from features and expected failures #5463

merged 3 commits into from
Jul 12, 2021

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Jul 7, 2021 •
edited
Loading

Description

Related Issue

Motivation and Context

do not use closed issue ref inside features or expected failure files

How Has This Been Tested?

  • 👨🏼‍🎨
  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@kiranparajuli589 kiranparajuli589 requested review from saw-jan, Talank and jasson99 and removed request for saw-jan and Talank July 7, 2021 05:20
@kiranparajuli589 kiranparajuli589 self-assigned this Jul 7, 2021
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/17113/22/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:104

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17113/47/1
The following scenarios passed on retry:

  • webUISharingAcceptShares/acceptShares.feature:100
  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oCISResharing1 https://drone.owncloud.com/owncloud/web/17113/57/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17114/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oCISResharing1 https://drone.owncloud.com/owncloud/web/17114/57/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@kiranparajuli589 kiranparajuli589 changed the title [tests-only][full_ci] remove more closed issue tags from features and expected failures [tests-only] [full_ci] remove more closed issue tags from features and expected failures Jul 7, 2021
@kiranparajuli589 kiranparajuli589 changed the title [tests-only] [full_ci] remove more closed issue tags from features and expected failures [tests-only] [full-ci] remove more closed issue tags from features and expected failures Jul 7, 2021
@kiranparajuli589 kiranparajuli589 force-pushed the remove-more-closed-issue-tags branch from 5fae18a to 0225682 Compare July 7, 2021 07:26
@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17117/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@kiranparajuli589 kiranparajuli589 force-pushed the remove-more-closed-issue-tags branch from 0225682 to 7e53b70 Compare July 7, 2021 08:28
@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17122/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsers https://drone.owncloud.com/owncloud/web/17122/23/1
The following scenarios passed on retry:

  • webUISharingInternalUsersShareWithPage/shareWithUsers.feature:91

Talank
Talank reviewed Jul 7, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SwikritiT
SwikritiT reviewed Jul 8, 2021
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpakach dpakach mentioned this pull request Jul 8, 2021
Merged
10 tasks
@kiranparajuli589 kiranparajuli589 force-pushed the remove-more-closed-issue-tags branch from 7e53b70 to f12d4fb Compare July 9, 2021 10:23
@kiranparajuli589 kiranparajuli589 requested a review from fschade as a code owner July 9, 2021 10:23
@kiranparajuli589 kiranparajuli589 force-pushed the remove-more-closed-issue-tags branch from b57e8fa to f94cfb3 Compare July 12, 2021 05:50
@phil-davis
Copy link
Contributor

@kiranparajuli589 I merged another commit-id-update PR just now, so you have conflicts - sorry!

Please rebase and resolve.

@kiranparajuli589 kiranparajuli589 force-pushed the remove-more-closed-issue-tags branch from f94cfb3 to 638c19c Compare July 12, 2021 06:20
@kiranparajuli589 kiranparajuli589 force-pushed the remove-more-closed-issue-tags branch from 638c19c to 8c711d6 Compare July 12, 2021 06:30
phil-davis
phil-davis approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@kiranparajuli589
Copy link
Contributor Author

LGTM if CI passes

there will be some line changes, I've removed some more closed issue tags. should be fixed in next commit

@phil-davis
Copy link
Contributor

LGTM if CI passes

there will be some line changes, I've removed some more closed issue tags. should be fixed in next commit

Yes, needs some line number changes:
https://drone.owncloud.com/owncloud/web/17272/54/9
https://drone.owncloud.com/owncloud/web/17272/55/9

It will be good to get this sorted out. Then we can make another commit id update in OCIS to bring in these changes...

@kiranparajuli589 kiranparajuli589 force-pushed the remove-more-closed-issue-tags branch from 8c711d6 to 29dd7c2 Compare July 12, 2021 07:15
@phil-davis
Copy link
Contributor

@kiranparajuli589 one more line number to change: https://drone.owncloud.com/owncloud/web/17280/54/9

@kiranparajuli589 kiranparajuli589 force-pushed the remove-more-closed-issue-tags branch from 29dd7c2 to 2eaaf6c Compare July 12, 2021 07:57
@kiranparajuli589 kiranparajuli589 force-pushed the remove-more-closed-issue-tags branch from 2eaaf6c to 9461760 Compare July 12, 2021 08:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 1d7ac8e into master Jul 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-more-closed-issue-tags branch July 12, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@Talank Talank Talank left review comments

@phil-davis phil-davis phil-davis approved these changes

@jasson99 jasson99 Awaiting requested review from jasson99

@saw-jan saw-jan Awaiting requested review from saw-jan

@fschade fschade Awaiting requested review from fschade

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiranparajuli589 @ownclouders @phil-davis @Talank @SwikritiT