[Tests-Only] add tests for sharing the shares_folder #5156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
reviewed
May 27, 2021
tests/acceptance/features/webUISharingPublicBasic/publicLinkCreate.feature
Outdated
Show resolved
Hide resolved
dpakach
force-pushed
the
share-shares-folder
branch
from
ae49c6d to
a546051
Compare
| Then( | ||
| 'the share permission denied message should be displayed in the sharing dialog on the webUI', | ||
| async function() { | ||
| const permissionDeniedMessage = "You don't have permission to share this folder." |
There was a problem hiding this comment.
why not getting this from feature?
There was a problem hiding this comment.
that part of the ui doens't shows any other type of message. Its only for the permission denied (as far as I have seen) so it makes more sense to make specific step for that.
individual-it
approved these changes
May 28, 2021
phil-davis
approved these changes
May 31, 2021
|
@LukasHirt @kulmann this is ready. Please merge it if you like, or wait until after #5018 |
LukasHirt
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test for sharing share_folder
Related Issue
Sharesfolder throws an error #5152Motivation and Context
How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: