Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to create a (public) link share of the Shares folder throws an error #5152

Closed
pascalwengerter opened this issue May 26, 2021 · 6 comments · Fixed by #6593
Closed

Trying to create a (public) link share of the Shares folder throws an error #5152

pascalwengerter opened this issue May 26, 2021 · 6 comments · Fixed by #6593

Comments

@pascalwengerter
Copy link
Contributor

pascalwengerter commented May 26, 2021

Steps to reproduce

  1. Go to all files
  2. Open right sidebar for Shares folder
  3. Try to create a public link for the folder

Expected behaviour

One perhaps shouldn't even see the buttons to create a public link for one's Shares folder

Actual behaviour

See an error

Screenshot 2021-05-26 at 09 46 51

@phil-davis
Copy link
Contributor

Is this with OCIS or oC10 server back-end, or both?

@pascalwengerter
Copy link
Contributor Author

Is this with OCIS or oC10 server back-end, or both?

Good point, oCIS from current master. We'll have to check this on the frontend independently of the backend though I suppose since you perhaps shouldn't be able to share your Shares folder from my understanding ;)

@phil-davis
Copy link
Contributor

The Shares folder is a system-wide thing. So it is a bit odd for a user to share the whole of it. The receiver would end up with a Shares/Shares folder! A product manager should decide what is the requirement, and we can easily first have an API test that checks for the desired behaviour.

@pascalwengerter
Copy link
Contributor Author

The Shares folder is a system-wide thing. So it is a bit odd for a user to share the whole of it. The receiver would end up with a Shares/Shares folder! A product manager should decide what is the requirement, and we can easily first have an API test that checks for the desired behaviour.

Agreed that it shouldn't be possible to do it, @tbsbdr could you take a look and add a corresponding story to our backlog?

@dpakach
Copy link
Contributor

dpakach commented May 27, 2021

Also when trying to create a user share, it doesn't shows any error message on ocis.
Screenshot from 2021-05-27 10-47-08

While on oc10 it shows error message
Screenshot from 2021-05-27 11-10-09

@pascalwengerter
Copy link
Contributor Author

Closed via #6593, in oCIS shares are now displayed in a different view and in OC10 the permissions are handled correctly, see screenshot below

Screenshot 2022-05-06 at 17 10 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants