Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format starlark definition #4987

Merged
merged 2 commits into from
May 6, 2021
Merged

Format starlark definition #4987

merged 2 commits into from
May 6, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Apr 20, 2021

Description

  • Format DroneCI Starlark definition with Buildifier (from Bazelbuild)
  • Add CI step to enforce DroneCI Starlark to be properly formatted in PRs

Related Issue

  • None

Motivation and Context

Have a nice formatted CI defintion

@wkloucek wkloucek force-pushed the format_starlark_definition branch 3 times, most recently from 88601b1 to 6b8305f Compare April 20, 2021 09:57
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14877/

20210420-100528-236.png
20210420-100601-902.png
20210420-100634-753.png
20210420-100723-252.png
20210420-100824-968.png
20210420-100859-429.png

@wkloucek wkloucek force-pushed the format_starlark_definition branch from 18ac40d to 0f4013a Compare April 21, 2021 07:48
@pascalwengerter pascalwengerter marked this pull request as ready for review April 21, 2021 15:02
@owncloud owncloud deleted a comment from update-docs bot Apr 22, 2021
@wkloucek wkloucek marked this pull request as draft April 22, 2021 07:08
@wkloucek
Copy link
Contributor Author

@pascalwengerter the format step in the CI pipeline still needs some love ;-) I want to use a dockerimage with buildifier already installed. This then can be used for all our pipelines

@wkloucek wkloucek force-pushed the format_starlark_definition branch from 86573f2 to a85d17d Compare May 6, 2021 08:47
@wkloucek wkloucek force-pushed the format_starlark_definition branch from 0cadbb1 to f42d58f Compare May 6, 2021 08:53
@wkloucek wkloucek marked this pull request as ready for review May 6, 2021 08:53
@wkloucek wkloucek merged commit 65059a6 into master May 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the format_starlark_definition branch May 6, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants