-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to official redis #4986
switch to official redis #4986
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation could be nicer 😉 but if CI is happy so am I
522e5dc
to
87de74e
Compare
.drone.star
Outdated
'REDIS_DATABASES': 1 | ||
}, | ||
}] | ||
}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how picky .star
files are, but this line is still one or two spaces off 🥴
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not really picky. The problem is, that I don't want to run a formatter on that Starlark file because it causes a huge diff :-(. We should do that once in an extra PR or in CI to enforce a specific formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, would you mind opening a GitHub issue for this so we don't forget? :) could be a good first issue
for outsiders, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will open a PR now ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is in #4987
87de74e
to
723b66c
Compare
💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14851/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎈
💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14854/
|
723b66c
to
c5257f2
Compare
💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14910/
|
Description
switch to official Redis docker image in CI
Related Issue
Motivation and Context
Use only maintained docker images