Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to official redis #4986

Merged
merged 1 commit into from
Apr 21, 2021
Merged

switch to official redis #4986

merged 1 commit into from
Apr 21, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Apr 20, 2021

Description

switch to official Redis docker image in CI

Related Issue

  • None

Motivation and Context

Use only maintained docker images

@update-docs
Copy link

update-docs bot commented Apr 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation could be nicer 😉 but if CI is happy so am I

@wkloucek wkloucek force-pushed the switch_to_official_redis branch from 522e5dc to 87de74e Compare April 20, 2021 07:30
.drone.star Outdated
'REDIS_DATABASES': 1
},
}]
}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how picky .star files are, but this line is still one or two spaces off 🥴

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not really picky. The problem is, that I don't want to run a formatter on that Starlark file because it causes a huge diff :-(. We should do that once in an extra PR or in CI to enforce a specific formatting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, would you mind opening a GitHub issue for this so we don't forget? :) could be a good first issue for outsiders, too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will open a PR now ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is in #4987

@wkloucek wkloucek force-pushed the switch_to_official_redis branch from 87de74e to 723b66c Compare April 20, 2021 07:46
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14851/

20210420-072858-176.png
20210420-072933-724.png
20210420-073008-548.png
20210420-073058-589.png
20210420-073133-393.png
20210420-073207-845.png
20210420-073241-608.png

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎈

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14854/

20210420-075313-824.png
20210420-075346-131.png
20210420-075516-357.png

@wkloucek wkloucek force-pushed the switch_to_official_redis branch from 723b66c to c5257f2 Compare April 21, 2021 07:35
@wkloucek wkloucek marked this pull request as ready for review April 21, 2021 07:36
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14910/

20210421-075008-297.png
20210421-075040-865.png
20210421-075114-213.png
20210421-075149-317.png
20210421-075410-040.png
20210421-075444-457.png

@wkloucek wkloucek merged commit 7c5a0c6 into master Apr 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the switch_to_official_redis branch April 21, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants