Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more forgiving with the server url #4536

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Be more forgiving with the server url #4536

merged 1 commit into from
Dec 17, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Dec 17, 2020

Description

This PR adds a check upon loading the config, if the server url has a trailing slash and adds it if missing. This was leading to wrong paths and therefor unresolved resources before (see screenshot).

How Has This Been Tested?

  • manually

Screenshots (if appropriate):

Screenshot 2020-12-17 at 12 17 24

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Dec 17, 2020
@kulmann kulmann self-assigned this Dec 17, 2020
@kulmann kulmann mentioned this pull request Dec 17, 2020
Closed
LukasHirt
LukasHirt approved these changes Dec 17, 2020
View reviewed changes
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - I never had a trailing slash in the server URL and it worked always just fine 🤷

@kulmann kulmann merged commit 5ea2d92 into master Dec 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the server-url-fix branch December 17, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@micbar micbar Awaiting requested review from micbar

@fschade fschade Awaiting requested review from fschade

Assignees

@kulmann kulmann

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @LukasHirt